fix: flaky test Wallet Created Events - Imported Account are sent when onboarding user who chooses to opt in metrics #37328

Unik0rnMaggie · 2025-10-28T16:03:58Z

Description

the test is failing with the following error:

AssertionError` [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  {
+   category: 'Onboarding',
-   category: 'App',
    chain_id: '0x1',
+   environment_type: 'fullscreen',
-   environment_type: 'background',
    locale: 'en'
  }

Verifying the captured events when failing, the App installed events are the same as when it succeeds, but in a different order:

Use method assertInAnyOrder for the fix

Changelog

CHANGELOG entry:

Related issues

Fixes: Flaky test Wallet Created Events - Imported Account are sent when onboarding user who chooses to opt in metrics

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Stabilizes the wallet-imported metrics e2e test by replacing order-dependent checks with assertInAnyOrder predicate assertions.

Tests (e2e/metrics):
- Switch to order-agnostic assertions using assertInAnyOrder in test/e2e/tests/metrics/wallet-imported.spec.ts.
  - Replace index-based event checks and deep equality with predicate-based assertions for:
    - App Installed (background) and App Installed (fullscreen)
    - Fourth onboarding event (fullscreen)
    - Firefox-only Analytics Preference Selected
    - Chrome-only Wallet Import Attempted
- Remove getNthEventByName helper usage and brittle sequence assertions.

^{Written by Cursor Bugbot for commit aefda6e. This will update automatically on new commits. Configure here.}

…n onboarding user who chooses to opt in metrics

github-actions · 2025-10-28T16:04:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-28T16:31:58Z

📊 Page Load Benchmark Results

Current Commit: 9789e0b | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±41ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 728ms (±36ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	41ms	1.01s	1.32s	1.07s	1.32s
domContentLoaded	728ms	36ms	697ms	980ms	751ms	980ms
firstPaint	78ms	11ms	60ms	172ms	88ms	172ms
firstContentfulPaint	78ms	11ms	60ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-28T16:32:07Z

Builds ready [9789e0b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1275 ± 79 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1275	1124	1453	79	1337	1405
			load	1094	947	1285	78	1141	1231
			domContentLoaded	1087	942	1274	77	1134	1223
			domInteractive	20	14	56	9	20	45
			firstPaint	572	89	1236	438	1116	1199
			backgroundConnect	233	220	254	7	237	249
			firstReactRender	27	18	53	6	30	39
			getState	18	8	35	6	21	29
			initialActions	6	0	44	7	7	23
			loadScripts	861	727	1042	76	905	1004
			setupStore	10	6	27	3	10	16
	Browserify	Power User Home	uiStartup	2116	1741	3242	522	2503	3242
			load	1055	846	1757	293	1453	1757
			domContentLoaded	1043	842	1701	283	1424	1701
			domInteractive	27	14	58	16	44	58
			firstPaint	813	179	1742	467	908	1742
			backgroundConnect	303	177	1053	241	298	1053
			firstReactRender	24	22	27	1	25	27
			getState	181	125	222	28	201	222
			initialActions	5	2	12	3	6	12
			loadScripts	832	665	1381	230	1128	1381
			setupStore	12	8	27	6	12	27
	Webpack	Standard Home	uiStartup	875	746	1180	78	888	1081
			load	649	597	980	66	656	766
			domContentLoaded	642	589	973	66	648	755
			domInteractive	17	12	48	9	15	45
			firstPaint	210	57	977	212	202	746
			backgroundConnect	25	12	54	8	29	40
			firstReactRender	29	17	94	12	34	46
			getState	12	6	23	4	15	17
			initialActions	4	0	17	3	5	10
			loadScripts	638	587	963	64	646	745
			setupStore	10	5	17	3	12	15
	Webpack	Power User Home	uiStartup	1739	1319	2401	340	1869	2401
			load	732	623	1122	142	872	1122
			domContentLoaded	701	609	1018	120	833	1018
			domInteractive	21	13	49	12	32	49
			firstPaint	345	110	889	278	628	889
			backgroundConnect	94	19	304	92	173	304
			firstReactRender	26	21	39	4	26	39
			getState	195	145	250	24	199	250
			initialActions	13	1	66	21	24	66
			loadScripts	696	607	1004	116	821	1004
			setupStore	20	6	81	23	31	81
Firefox	Browserify	Standard Home	uiStartup	1422	1241	1783	106	1484	1643
			load	1210	1073	1423	79	1257	1365
			domContentLoaded	1209	1073	1423	79	1257	1365
			domInteractive	112	36	235	40	120	201
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	24	137	17	45	74
			firstReactRender	25	20	73	8	25	45
			getState	7	4	73	8	7	11
			initialActions	4	1	186	18	3	5
			loadScripts	1185	1056	1378	75	1228	1343
			setupStore	12	6	183	17	12	14
	Browserify	Power User Home	uiStartup	2821	2259	4088	607	3523	4088
			load	1394	1164	1996	213	1529	1996
			domContentLoaded	1393	1164	1995	213	1529	1995
			domInteractive	177	103	418	95	255	418
			firstPaint	-	-	-	-	-	-
			backgroundConnect	189	32	614	179	332	614
			firstReactRender	47	28	89	16	47	89
			getState	164	115	219	29	190	219
			initialActions	10	1	48	13	14	48
			loadScripts	1331	1136	1751	174	1466	1751
			setupStore	30	6	89	25	46	89
	Webpack	Standard Home	uiStartup	1619	1451	2087	129	1669	1923
			load	1379	1219	1807	101	1428	1591
			domContentLoaded	1379	1218	1807	101	1428	1591
			domInteractive	112	32	471	78	108	374
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	23	186	25	54	103
			firstReactRender	29	22	141	13	29	40
			getState	8	4	60	6	8	15
			initialActions	6	1	175	19	4	12
			loadScripts	1347	1198	1780	99	1389	1541
			setupStore	15	7	74	12	14	50
	Webpack	Power User Home	uiStartup	2861	2373	3691	413	3263	3691
			load	1667	1384	2404	279	1819	2404
			domContentLoaded	1666	1384	2403	279	1819	2403
			domInteractive	182	63	946	209	192	946
			firstPaint	-	-	-	-	-	-
			backgroundConnect	168	46	472	135	279	472
			firstReactRender	41	28	80	13	46	80
			getState	124	79	197	31	140	197
			initialActions	9	1	44	11	10	44
			loadScripts	1600	1341	2372	254	1736	2372
			setupStore	32	5	130	30	40	130

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 172 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-10-29T13:24:33Z

📊 Page Load Benchmark Results

Current Commit: aefda6e | Date: 10/29/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±42ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 716ms (±38ms) 🟢 | historical mean value: 744ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 83ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	42ms	1000ms	1.33s	1.07s	1.33s
domContentLoaded	716ms	38ms	691ms	993ms	753ms	993ms
firstPaint	76ms	11ms	56ms	164ms	84ms	164ms
firstContentfulPaint	76ms	11ms	56ms	164ms	84ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-29T13:24:39Z

Builds ready [aefda6e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1302 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1302	1129	1599	96	1367	1465
			load	1121	969	1428	94	1178	1282
			domContentLoaded	1115	964	1423	93	1171	1275
			domInteractive	20	13	58	10	19	46
			firstPaint	586	74	1334	455	1109	1256
			backgroundConnect	234	220	261	7	239	250
			firstReactRender	28	18	61	8	31	46
			getState	19	7	71	8	22	30
			initialActions	5	0	50	6	5	17
			loadScripts	887	737	1197	93	940	1051
			setupStore	10	6	20	2	10	14
	Browserify	Power User Home	uiStartup	2242	1796	3654	583	3028	3654
			load	1174	932	1912	336	1584	1912
			domContentLoaded	1160	928	1862	322	1575	1862
			domInteractive	28	16	85	20	47	85
			firstPaint	807	200	1900	577	1039	1900
			backgroundConnect	279	230	698	111	293	698
			firstReactRender	26	22	33	3	28	33
			getState	192	155	291	40	209	291
			initialActions	8	2	54	12	5	54
			loadScripts	912	701	1502	291	1290	1502
			setupStore	12	8	27	6	13	27
	Webpack	Standard Home	uiStartup	886	763	1214	81	903	1080
			load	665	605	973	77	678	899
			domContentLoaded	657	599	960	76	672	888
			domInteractive	16	12	55	7	14	35
			firstPaint	207	58	893	197	209	635
			backgroundConnect	26	14	70	9	30	41
			firstReactRender	28	16	100	11	34	37
			getState	12	6	34	4	15	19
			initialActions	4	1	26	4	5	8
			loadScripts	654	596	947	74	669	874
			setupStore	10	5	24	4	13	15
	Webpack	Power User Home	uiStartup	1498	1155	2087	284	1610	2087
			load	628	551	920	96	713	920
			domContentLoaded	602	539	811	74	687	811
			domInteractive	18	12	43	9	29	43
			firstPaint	381	74	724	251	607	724
			backgroundConnect	100	11	424	119	106	424
			firstReactRender	24	22	29	2	25	29
			getState	137	86	167	16	140	167
			initialActions	15	1	75	23	34	75
			loadScripts	598	537	804	72	678	804
			setupStore	25	5	93	26	37	93
Firefox	Browserify	Standard Home	uiStartup	1369	1205	1724	96	1413	1619
			load	1174	1047	1343	64	1217	1273
			domContentLoaded	1173	1047	1343	64	1216	1273
			domInteractive	102	36	226	37	118	201
			firstPaint	-	-	-	-	-	-
			backgroundConnect	37	22	93	12	43	62
			firstReactRender	24	19	51	6	24	42
			getState	9	3	160	17	8	14
			initialActions	5	1	192	19	3	7
			loadScripts	1151	1027	1319	63	1190	1257
			setupStore	11	6	73	7	11	20
	Browserify	Power User Home	uiStartup	2617	2231	3523	359	2886	3523
			load	1391	1205	1667	118	1501	1667
			domContentLoaded	1391	1204	1666	118	1500	1666
			domInteractive	157	80	288	64	209	288
			firstPaint	-	-	-	-	-	-
			backgroundConnect	172	34	474	143	319	474
			firstReactRender	40	29	54	8	47	54
			getState	141	71	281	48	162	281
			initialActions	23	1	152	42	20	152
			loadScripts	1324	1182	1516	103	1449	1516
			setupStore	36	7	138	35	51	138
	Webpack	Standard Home	uiStartup	1613	1377	2215	131	1679	1856
			load	1387	1196	1716	98	1447	1558
			domContentLoaded	1386	1196	1715	98	1447	1558
			domInteractive	109	34	551	64	112	209
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	24	131	21	52	90
			firstReactRender	26	22	61	4	27	33
			getState	10	4	132	16	9	16
			initialActions	5	0	68	11	3	24
			loadScripts	1356	1176	1693	95	1421	1531
			setupStore	14	6	182	19	13	31
	Webpack	Power User Home	uiStartup	2894	2377	3572	364	3167	3572
			load	1648	1409	1965	173	1816	1965
			domContentLoaded	1647	1408	1964	173	1815	1964
			domInteractive	167	91	466	96	214	466
			firstPaint	-	-	-	-	-	-
			backgroundConnect	200	35	615	143	296	615
			firstReactRender	45	31	100	16	51	100
			getState	131	72	250	38	148	250
			initialActions	13	2	26	10	24	26
			loadScripts	1577	1375	1914	153	1701	1914
			setupStore	49	7	176	43	65	176

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -21.75 KiB (-0.47%)
ui: 23.51 KiB (0.33%)
common: 23.73 KiB (0.27%)

seaona

LGTM

fix: flaky test Wallet Created Events - Imported Account are sent whe…

9789e0b

…n onboarding user who chooses to opt in metrics

metamaskbot added the team-qa QA team label Oct 28, 2025

github-actions bot added the size-S label Oct 28, 2025

fix

aefda6e

seaona added flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Oct 29, 2025

seaona assigned Unik0rnMaggie Oct 29, 2025

github-actions bot added size-M and removed size-S labels Oct 29, 2025

seaona marked this pull request as ready for review October 29, 2025 13:30

seaona approved these changes Oct 29, 2025

View reviewed changes

seaona enabled auto-merge October 29, 2025 13:32

chloeYue approved these changes Oct 29, 2025

View reviewed changes

seaona added this pull request to the merge queue Oct 29, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2025

Unik0rnMaggie added this pull request to the merge queue Oct 29, 2025

Merged via the queue into main with commit 6ed6acf Oct 29, 2025
185 of 187 checks passed

Unik0rnMaggie deleted the flaky-wallet-created-events branch October 29, 2025 15:28

github-actions bot locked and limited conversation to collaborators Oct 29, 2025

metamaskbot added the release-13.8.0 Issue or pull request that will be included in release 13.8.0 label Oct 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: flaky test Wallet Created Events - Imported Account are sent when onboarding user who chooses to opt in metrics #37328

fix: flaky test Wallet Created Events - Imported Account are sent when onboarding user who chooses to opt in metrics #37328

Uh oh!

Unik0rnMaggie commented Oct 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

metamaskbot commented Oct 28, 2025

Uh oh!

metamaskbot commented Oct 28, 2025

Uh oh!

metamaskbot commented Oct 29, 2025

Uh oh!

metamaskbot commented Oct 29, 2025

Uh oh!

seaona left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: flaky test Wallet Created Events - Imported Account are sent when onboarding user who chooses to opt in metrics #37328

fix: flaky test Wallet Created Events - Imported Account are sent when onboarding user who chooses to opt in metrics #37328

Uh oh!

Conversation

Unik0rnMaggie commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

metamaskbot commented Oct 28, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 28, 2025

Uh oh!

metamaskbot commented Oct 29, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 29, 2025

Uh oh!

seaona left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Unik0rnMaggie commented Oct 28, 2025 •

edited

Loading