-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat(smart account): use auto-upgrade for gasIncluded7702 swaps #39022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (2 files, +35 -167)
|
Builds ready [4de9381]
UI Startup Metrics (1344 ± 117 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
4de9381 to
d1e186f
Compare
d1e186f to
8bf1956
Compare
8bf1956 to
10c980e
Compare
Builds ready [10c980e]
UI Startup Metrics (1278 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
10c980e to
72270f9
Compare
Builds ready [72270f9]
UI Startup Metrics (1277 ± 114 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
72270f9 to
9c71c17
Compare
9c71c17 to
e9b7495
Compare
Builds ready [e9b7495]
UI Startup Metrics (1289 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [e9b7495]
UI Startup Metrics (1289 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [e9b7495]
UI Startup Metrics (1289 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
e9b7495 to
6666cfd
Compare
Builds ready [6666cfd]
UI Startup Metrics (1265 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Use auto-upgrade for gas-included swaps with 7702
Changelog
CHANGELOG entry: Removed the check for smart account when assessing support for gas included swaps with 7702
Related issues
Fixes:
Manual testing steps
Given the user does not have a smart account on Base/Arbitrum/Polygon
And no native currency to pay for gas
When the use swaps a non native token
Then the quote has gas included
When the user submits the swaps
Then the swap is successful
And the user account is upgraded to a smart account for this network
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Streamlines the gas-included 7702 support check to depend only on relay availability.
useGasIncluded7702to callisRelaySupported(formatChainIdToHex(chainId))and removesisAtomicBatchSupportedand smart account opt-in (getUseSmartAccount) logicisSendBundleSupportedForChain && getIsSmartTransaction(...), non-swap, missing account/chain, or non-EVM chainuseGasIncluded7702.test.tsto drop atomic batch expectations, add/adjust cases for relay-supported/unsupported, error handling, and race-condition scenariosWritten by Cursor Bugbot for commit 6666cfd. This will update automatically on new commits. Configure here.