Skip to content

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Jan 6, 2026

Description

This PR aims to apply word break on the permissions modal.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Fix permission modal to show entire origin when it's too long

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6493

Manual testing steps

See task details for

Screenshots/Recordings

Before

Screenshot 2026-01-06 at 12 00 28

After

Screenshot 2026-01-06 at 11 59 44

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Improves readability of long site origins in the permissions modal.

  • Adds className="break-all" to the Text displaying displayOrigin in permission-page-container-content.component.js so long origins wrap instead of overflowing

Written by Cursor Bugbot for commit 42a6553. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 6, 2026
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 6, 2026

Builds ready [ca7a44b]
UI Startup Metrics (1338 ± 109 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13381030170110913921495
load1114882146210311711279
domContentLoaded1108880145610211651272
domInteractive271699202488
firstPaint183671213180203326
backgroundConnect22520428513230250
firstReactRender1393141423
getState361992134055
initialActions105111
loadScripts89167512251019491071
setupStore1173141220
numNetworkReqs171172161166
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup795659101875840939
load63657779659651773
domContentLoaded63157278959647768
domInteractive2516104202190
firstPaint1076061873120236
backgroundConnect265112273199
firstReactRender15113151727
getState331597154468
initialActions104112
loadScripts62857078057644759
setupStore1263761231
numNetworkReqs181176171169
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
FirefoxBrowserifyStandard HomeuiStartup13871085243925014611950
load1109914221719911471574
domContentLoaded1109914221719911461573
domInteractive8630109513391163
firstPaint------
backgroundConnect61213706470201
firstReactRender1294341216
getState116124121020
initialActions102012
loadScripts1075900211517811151448
setupStore144203231146
numNetworkReqs19978191475
BrowserifyPower User HomeuiStartup25891523421557129683252
load17041004253452722012468
domContentLoaded17041004253452722002468
domInteractive813199110875251
firstPaint------
backgroundConnect3952211654035081123
firstReactRender21115392544
getState986222831109166
initialActions204123
loadScripts1401979234344018352247
setupStore784108622238948
numNetworkReqs60201453266139
WebpackStandard HomeuiStartup15571297216517116511898
load13091111157411114021512
domContentLoaded13091111157411114011511
domInteractive762918140106141
firstPaint------
backgroundConnect63202654877167
firstReactRender14102531520
getState167205231445
initialActions102122
loadScripts1268107915519513441424
setupStore195248321664
numNetworkReqs20987201377
WebpackPower User HomeuiStartup26691738379149729923479
load19551178277946823582508
domContentLoaded19541178277946823582508
domInteractive832885611985275
firstPaint------
backgroundConnect4012111964019111145
firstReactRender19128292034
getState945721330102159
initialActions2050523
loadScripts16431163248439320672271
setupStore324104810720113
numNetworkReqs63211653567146
📊 Page Load Benchmark Results

Current Commit: ca7a44b | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±44ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±39ms) 🟢 | historical mean value: 732ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 44ms 1.01s 1.35s 1.09s 1.35s
domContentLoaded 732ms 39ms 695ms 1.00s 767ms 1.00s
firstPaint 77ms 13ms 60ms 192ms 84ms 192ms
firstContentfulPaint 77ms 13ms 60ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 59 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 6, 2026

Builds ready [fd555dd]
UI Startup Metrics (1244 ± 111 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12441019151611113211471
load1038837131910210981247
domContentLoaded1031832131410110911240
domInteractive2414107181976
firstPaint174581112160180283
backgroundConnect20217924412210225
firstReactRender1493051528
getState351666114062
initialActions104111
loadScripts83864511221008881047
setupStore1252541420
numNetworkReqs181178181172
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup779639113382824923
load63156491365655765
domContentLoaded62656090765651758
domInteractive2415117201979
firstPaint1085859571138213
backgroundConnect245133253384
firstReactRender15103441626
getState311472134056
initialActions104111
loadScripts62355889763648749
setupStore1243961326
numNetworkReqs171179171168
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
FirefoxBrowserifyStandard HomeuiStartup14211098457737514761789
load1107930210516511501432
domContentLoaded1107930210516511501432
domInteractive7532117411688135
firstPaint------
backgroundConnect56212024573172
firstReactRender1394141322
getState136115131239
initialActions102122
loadScripts1075914208915611241414
setupStore144218231137
numNetworkReqs19979191375
BrowserifyPower User HomeuiStartup24241405321148728123067
load1669961241948520822375
domContentLoaded1669961241948520812375
domInteractive83358159081221
firstPaint------
backgroundConnect3382211453463511051
firstReactRender2211170192451
getState11237912122103210
initialActions204123
loadScripts1413947225542718902209
setupStore48595510361168
numNetworkReqs68211663377154
WebpackStandard HomeuiStartup15801326231218416931894
load13221125170512414061551
domContentLoaded13221124170412514051550
domInteractive75291773696135
firstPaint------
backgroundConnect60162514576158
firstReactRender16116861626
getState175213251346
initialActions103122
loadScripts12851094168011213381520
setupStore2252243516105
numNetworkReqs19979191477
WebpackPower User HomeuiStartup26631563367754430993363
load20081106275350824552631
domContentLoaded20071105275250824542631
domInteractive1003098316091324
firstPaint------
backgroundConnect2892511773033461096
firstReactRender211391112342
getState1046126542118213
initialActions205123
loadScripts17981089262444222012476
setupStore2742143928112
numNetworkReqs67231883674162
📊 Page Load Benchmark Results

Current Commit: fd555dd | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±48ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±44ms) 🟢 | historical mean value: 732ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 48ms 1.02s 1.42s 1.10s 1.42s
domContentLoaded 734ms 44ms 705ms 1.09s 773ms 1.09s
firstPaint 77ms 13ms 64ms 192ms 88ms 192ms
firstContentfulPaint 77ms 13ms 64ms 192ms 88ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 22 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 6, 2026

Builds ready [42a6553]
UI Startup Metrics (1222 ± 108 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1222969152410812891384
load102081112969810721200
domContentLoaded101480312919710631189
domInteractive241497191981
firstPaint171581043148181270
backgroundConnect19517323712200223
firstReactRender1493951424
getState3316104123650
initialActions104111
loadScripts826626109797881976
setupStore1164651215
numNetworkReqs181177171170
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup77363294072819901
load61655381564635764
domContentLoaded61154981064630759
domInteractive2415100201985
firstPaint1105779484143194
backgroundConnect4061494081116
firstReactRender15103241625
getState271459103449
initialActions103111
loadScripts60854780863625752
setupStore1062031117
numNetworkReqs181177171172
WebpackPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
FirefoxBrowserifyStandard HomeuiStartup14311139235221415101904
load1149932213517812061410
domContentLoaded1148931213517912061410
domInteractive8932107213393177
firstPaint------
backgroundConnect63213706069169
firstReactRender1393631319
getState136102131235
initialActions102122
loadScripts1109917211716611571325
setupStore174183261350
numNetworkReqs19981191474
BrowserifyPower User HomeuiStartup27091525553369131013464
load18091028412662222642654
domContentLoaded18091028412662222632654
domInteractive10330251325190270
firstPaint------
backgroundConnect4252213004169551147
firstReactRender18126162126
getState1076251256114225
initialActions203123
loadScripts14861001410157320162466
setupStore946121522967936
numNetworkReqs69231803474164
WebpackStandard HomeuiStartup15851328210315217111839
load13081119158710513641524
domContentLoaded13081119158710513641523
domInteractive863018541125148
firstPaint------
backgroundConnect56171533568137
firstReactRender15102731622
getState186202301590
initialActions103122
loadScripts1274108715679413341453
setupStore156120141440
numNetworkReqs20991201478
WebpackPower User HomeuiStartup27841651370354732053538
load20621195299653225302667
domContentLoaded20621194299553225302667
domInteractive933091011591333
firstPaint------
backgroundConnect3732511833754261128
firstReactRender2213148152746
getState119671142110126220
initialActions206123
loadScripts17861173283744222342442
setupStore735116020442231
numNetworkReqs69191773485154
📊 Page Load Benchmark Results

Current Commit: 42a6553 | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±47ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 728ms (±43ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 47ms 1.02s 1.42s 1.08s 1.42s
domContentLoaded 728ms 43ms 701ms 1.08s 759ms 1.08s
firstPaint 77ms 13ms 60ms 196ms 84ms 196ms
firstContentfulPaint 77ms 13ms 60ms 196ms 84ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 22 Bytes (0%)
  • common: 20 Bytes (0%)

@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit a97d260 Jan 9, 2026
174 of 176 checks passed
@OGPoyraz OGPoyraz deleted the ogp/6493 branch January 9, 2026 10:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
@metamaskbot metamaskbot added the release-13.15.0 Issue or pull request that will be included in release 13.15.0 label Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.15.0 Issue or pull request that will be included in release 13.15.0 size-XS team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants