fix: updated appActiveTab to check dapp url #39040

NidhiKJha · 2026-01-06T14:12:45Z

This PR ensures that the active tab url is updated correctly when the tabs are changed. This issue is specific to sidepanel since the side panel stays open and relies on browser.tabs.onActivated and browser.tabs.onUpdated listeners to keep appActiveTab updated in real-time. When those listeners didn't properly clear the state for chrome://newtab, the side panel showed stale data from the previous tab.

Changelog

CHANGELOG entry:null

Related issues

Fixes: #38859

Manual testing steps

Open MM on the side panel
Open test dapp
Click on the Connected site icon
See test dapp url
Open a new browser tab
If it's not a dapp, connected site icon won't show up

Screenshots/Recordings

Before

NA

After

Screen.Recording.2026-01-06.at.2.11.18.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Improves correctness of sidepanel appActiveTab state and reduces stale data.

Validate URLs with isWebUrl; clear appActiveTab for non-web/blank and extension pages in tabs.onActivated and tabs.onUpdated
Restrict tabs.onUpdated handling to the active tab and only when changeInfo.url is present; use the provided tab object instead of re-querying
Add AppStateController.clearAppActiveTab() and expose it via MetamaskController for background usage
Continue updating subject metadata when a valid web URL becomes active

^{Written by Cursor Bugbot for commit f30e045. This will update automatically on new commits. Configure here.}

metamaskbotv2 · 2026-01-06T14:45:15Z

Builds ready [6f2e6cc]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1296 ± 134 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1296	1045	1740	134	1363	1543
			load	1088	863	1523	126	1151	1341
			domContentLoaded	1082	860	1518	125	1144	1335
			domInteractive	26	15	97	19	23	88
			firstPaint	158	63	1051	159	187	297
			backgroundConnect	214	193	246	10	222	234
			firstReactRender	14	9	36	4	15	21
			getState	35	17	97	13	39	59
			initialActions	1	0	12	1	1	2
			loadScripts	875	660	1289	124	940	1125
			setupStore	12	7	31	4	13	20
			numNetworkReqs	17	11	77	16	11	65
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	782	647	1051	76	819	956
			load	634	575	917	64	653	773
			domContentLoaded	630	571	912	64	647	768
			domInteractive	25	15	109	19	21	82
			firstPaint	105	61	333	52	133	208
			backgroundConnect	23	5	111	20	33	62
			firstReactRender	15	11	27	3	17	22
			getState	35	15	131	19	43	65
			initialActions	1	0	2	1	1	2
			loadScripts	626	568	903	62	645	760
			setupStore	13	7	61	9	14	37
			numNetworkReqs	17	11	75	17	11	68
	Webpack	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
Firefox	Browserify	Standard Home	uiStartup	1442	1133	2232	215	1566	1902
			load	1148	946	1873	155	1204	1410
			domContentLoaded	1147	946	1873	155	1204	1410
			domInteractive	72	31	236	43	89	157
			firstPaint	-	-	-	-	-	-
			backgroundConnect	65	20	306	55	87	196
			firstReactRender	13	10	34	4	13	24
			getState	21	6	553	60	12	38
			initialActions	1	0	3	1	2	2
			loadScripts	1106	932	1850	136	1163	1345
			setupStore	14	4	164	18	12	45
			numNetworkReqs	19	9	85	19	14	74
	Browserify	Power User Home	uiStartup	2365	1384	3139	489	2735	2992
			load	1650	970	2426	463	2042	2265
			domContentLoaded	1649	970	2425	462	2042	2264
			domInteractive	74	33	458	71	74	262
			firstPaint	-	-	-	-	-	-
			backgroundConnect	355	18	1118	351	434	996
			firstReactRender	21	11	80	10	24	45
			getState	110	61	1000	124	114	214
			initialActions	2	1	9	1	2	6
			loadScripts	1382	951	2274	406	1837	2115
			setupStore	61	6	996	137	54	186
			numNetworkReqs	68	11	183	35	77	163
	Webpack	Standard Home	uiStartup	1700	1379	2350	199	1822	2072
			load	1393	1175	1742	137	1461	1672
			domContentLoaded	1392	1170	1741	137	1461	1672
			domInteractive	86	30	271	47	119	147
			firstPaint	-	-	-	-	-	-
			backgroundConnect	68	20	345	52	78	175
			firstReactRender	16	11	64	6	17	23
			getState	22	6	223	35	15	109
			initialActions	1	0	3	1	2	3
			loadScripts	1349	1159	1655	111	1428	1578
			setupStore	22	5	149	29	16	100
			numNetworkReqs	19	9	82	19	14	73
	Webpack	Power User Home	uiStartup	2706	1667	3672	569	3158	3551
			load	2003	1193	2901	523	2476	2744
			domContentLoaded	2002	1193	2900	523	2475	2743
			domInteractive	88	30	893	130	86	252
			firstPaint	-	-	-	-	-	-
			backgroundConnect	328	29	1132	338	385	1057
			firstReactRender	19	13	58	7	21	28
			getState	110	60	377	53	127	216
			initialActions	2	0	7	1	2	2
			loadScripts	1765	1174	2714	453	2199	2639
			setupStore	46	4	1104	117	48	183
			numNetworkReqs	68	25	189	33	81	149

📊 Page Load Benchmark Results

Current Commit: 6f2e6cc | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 727ms (±38ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	40ms	1.01s	1.33s	1.08s	1.33s
domContentLoaded	727ms	38ms	700ms	1.00s	761ms	1.00s
firstPaint	76ms	11ms	60ms	172ms	88ms	172ms
firstContentfulPaint	76ms	11ms	60ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 362 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

metamaskbotv2 · 2026-01-06T16:18:27Z

Builds ready [f30e045]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1247 ± 99 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1247	1028	1517	99	1305	1421
			load	1045	867	1286	92	1104	1220
			domContentLoaded	1038	859	1277	91	1098	1214
			domInteractive	25	16	100	19	23	76
			firstPaint	164	62	1047	160	192	282
			backgroundConnect	209	189	263	12	213	232
			firstReactRender	13	8	27	4	15	20
			getState	35	17	65	10	40	55
			initialActions	1	0	4	1	1	2
			loadScripts	835	662	1080	92	900	1014
			setupStore	12	6	33	5	13	23
			numNetworkReqs	17	10	72	16	11	67
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	815	664	1030	80	863	979
			load	658	575	892	67	682	805
			domContentLoaded	653	571	884	66	675	799
			domInteractive	26	16	98	19	23	80
			firstPaint	109	60	638	77	115	244
			backgroundConnect	23	6	128	28	26	105
			firstReactRender	16	10	32	4	18	27
			getState	35	15	128	17	44	60
			initialActions	1	0	10	1	1	2
			loadScripts	650	569	875	65	672	790
			setupStore	12	5	38	6	13	25
			numNetworkReqs	18	11	75	18	11	71
	Webpack	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
Firefox	Browserify	Standard Home	uiStartup	1414	1060	2065	183	1525	1759
			load	1125	912	1409	118	1212	1336
			domContentLoaded	1125	911	1409	118	1212	1336
			domInteractive	72	32	331	49	90	179
			firstPaint	-	-	-	-	-	-
			backgroundConnect	66	20	326	60	83	208
			firstReactRender	13	9	30	3	14	22
			getState	14	5	138	19	12	38
			initialActions	1	0	3	1	2	2
			loadScripts	1086	897	1301	97	1165	1259
			setupStore	13	4	95	13	12	41
			numNetworkReqs	19	9	90	20	13	76
	Browserify	Power User Home	uiStartup	2626	1535	4118	578	3012	3509
			load	1753	1004	2807	554	2236	2540
			domContentLoaded	1753	999	2807	554	2235	2540
			domInteractive	98	33	912	114	92	330
			firstPaint	-	-	-	-	-	-
			backgroundConnect	374	29	1165	378	447	1103
			firstReactRender	23	12	190	19	26	54
			getState	113	49	910	88	126	179
			initialActions	2	0	8	1	2	3
			loadScripts	1478	988	2601	455	2006	2276
			setupStore	66	6	1055	172	54	225
			numNetworkReqs	69	21	175	34	78	162
	Webpack	Standard Home	uiStartup	1571	1253	2096	171	1659	1903
			load	1323	1078	1740	116	1388	1527
			domContentLoaded	1323	1078	1740	117	1388	1527
			domInteractive	85	29	196	35	118	134
			firstPaint	-	-	-	-	-	-
			backgroundConnect	65	19	332	53	80	166
			firstReactRender	15	11	30	3	15	23
			getState	16	6	142	21	14	51
			initialActions	1	0	3	1	2	2
			loadScripts	1283	1066	1586	98	1332	1504
			setupStore	18	4	180	27	14	95
			numNetworkReqs	20	9	85	20	14	78
	Webpack	Power User Home	uiStartup	2775	1655	3798	561	3214	3567
			load	2088	1182	3034	550	2542	2787
			domContentLoaded	2087	1182	3034	550	2542	2787
			domInteractive	114	29	1328	201	82	413
			firstPaint	-	-	-	-	-	-
			backgroundConnect	364	24	1193	360	396	1131
			firstReactRender	19	13	75	8	20	28
			getState	101	64	275	37	106	173
			initialActions	2	0	7	1	2	3
			loadScripts	1811	1124	2862	483	2289	2602
			setupStore	48	4	950	107	47	208
			numNetworkReqs	68	23	174	33	81	157

📊 Page Load Benchmark Results

Current Commit: f30e045 | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±44ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 722ms (±41ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±16ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	44ms	1.01s	1.38s	1.08s	1.38s
domContentLoaded	722ms	41ms	699ms	1.04s	761ms	1.04s
firstPaint	77ms	16ms	60ms	228ms	88ms	228ms
firstContentfulPaint	77ms	16ms	60ms	228ms	88ms	228ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 362 Bytes (0.01%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

updated appActiveTab to check dapp url

6f2e6cc

NidhiKJha temporarily deployed to pr-comment January 6, 2026 14:12 — with GitHub Actions Inactive

metamaskbot added team-core-extension-ux Core Extension UX team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 6, 2026

github-actions bot added the size-S label Jan 6, 2026

NidhiKJha temporarily deployed to pr-comment January 6, 2026 14:40 — with GitHub Actions Inactive

Merge branch 'main' into fix-38859

f30e045

NidhiKJha temporarily deployed to pr-comment January 6, 2026 15:45 — with GitHub Actions Inactive

NidhiKJha temporarily deployed to pr-comment January 6, 2026 16:14 — with GitHub Actions Inactive

NidhiKJha added the DO-NOT-MERGE Pull requests that should not be merged label Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: updated appActiveTab to check dapp url #39040

fix: updated appActiveTab to check dapp url #39040

NidhiKJha commented Jan 6, 2026 •

edited by cursor bot

Loading

Uh oh!

metamaskbotv2 bot commented Jan 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: updated appActiveTab to check dapp url #39040

Are you sure you want to change the base?

fix: updated appActiveTab to check dapp url #39040

Conversation

NidhiKJha commented Jan 6, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbotv2 bot commented Jan 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NidhiKJha commented Jan 6, 2026 •

edited by cursor bot

Loading