fix: Update `MenuItem` info dot #39042

GuillaumeRx · 2026-01-06T14:50:09Z

Description

This PR fixes the info dot of the menu item by using a div instead of the Icon that doesn't have a background.

Changelog

CHANGELOG entry: fix MenuItem info dot

Related issues

Fixes:

Manual testing steps

look at the info dot in the extension menu

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Fix menu info dot rendering

Replace badge Icon with a styled Box (10px circle, primaryDefault background) for the info dot in MenuItem
Adjust BadgeWrapper positionObj from { top: -6, right: 4 } to { top: 0, right: 4 }
Add imports for Box, BackgroundColor, and BorderRadius

^{Written by Cursor Bugbot for commit 4264832. This will update automatically on new commits. Configure here.}

github-actions · 2026-01-06T14:50:18Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-01-06T15:45:21Z

Builds ready [4264832]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1311 ± 110 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1311	1014	1688	110	1377	1467
			load	1091	863	1465	102	1167	1229
			domContentLoaded	1085	857	1459	102	1163	1224
			domInteractive	27	15	106	20	23	85
			firstPaint	197	68	1202	207	202	325
			backgroundConnect	222	201	272	11	229	240
			firstReactRender	14	9	31	5	16	28
			getState	36	17	74	11	40	60
			initialActions	1	0	8	1	1	2
			loadScripts	870	658	1243	101	948	1005
			setupStore	13	5	51	6	12	28
			numNetworkReqs	18	11	81	17	11	69
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	806	658	1197	80	858	925
			load	649	585	915	64	669	800
			domContentLoaded	644	580	908	63	662	793
			domInteractive	26	16	148	21	22	80
			firstPaint	106	62	322	55	121	222
			backgroundConnect	25	5	133	30	30	110
			firstReactRender	15	11	35	4	18	24
			getState	34	15	133	20	41	70
			initialActions	1	0	4	1	1	3
			loadScripts	641	578	900	62	659	783
			setupStore	13	7	47	8	14	39
			numNetworkReqs	17	11	73	17	11	69
	Webpack	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
Firefox	Browserify	Standard Home	uiStartup	1510	1203	1934	152	1623	1810
			load	1209	1032	1587	111	1264	1426
			domContentLoaded	1209	1026	1587	111	1264	1425
			domInteractive	89	37	242	47	107	209
			firstPaint	-	-	-	-	-	-
			backgroundConnect	72	23	347	57	106	185
			firstReactRender	13	10	22	2	14	18
			getState	14	6	108	16	12	49
			initialActions	1	0	3	1	2	2
			loadScripts	1161	990	1498	88	1218	1328
			setupStore	15	5	200	21	13	45
			numNetworkReqs	21	9	86	21	15	83
	Browserify	Power User Home	uiStartup	2562	1488	3555	541	3018	3206
			load	1765	1015	2741	534	2253	2479
			domContentLoaded	1765	1015	2741	534	2252	2479
			domInteractive	90	33	919	110	85	298
			firstPaint	-	-	-	-	-	-
			backgroundConnect	356	20	1335	359	451	1097
			firstReactRender	19	12	62	7	23	28
			getState	101	65	293	32	118	155
			initialActions	2	0	7	1	2	3
			loadScripts	1515	996	2568	467	2001	2302
			setupStore	62	5	1017	146	69	208
			numNetworkReqs	69	30	176	32	78	159
	Webpack	Standard Home	uiStartup	1512	1254	1961	161	1575	1873
			load	1282	1089	1538	100	1333	1477
			domContentLoaded	1281	1089	1538	100	1333	1476
			domInteractive	77	27	181	37	102	132
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	17	204	34	59	124
			firstReactRender	14	10	44	4	15	21
			getState	15	7	206	22	14	45
			initialActions	1	0	4	1	2	2
			loadScripts	1248	1076	1497	93	1304	1432
			setupStore	16	4	138	22	14	50
			numNetworkReqs	19	9	85	19	13	77
	Webpack	Power User Home	uiStartup	2683	1652	3399	539	3118	3337
			load	2026	1096	2767	533	2486	2690
			domContentLoaded	2026	1096	2767	534	2486	2690
			domInteractive	73	29	1041	110	66	161
			firstPaint	-	-	-	-	-	-
			backgroundConnect	337	26	1165	351	408	1083
			firstReactRender	20	13	154	15	22	31
			getState	96	62	235	31	102	168
			initialActions	2	0	3	1	2	2
			loadScripts	1774	1081	2744	463	2219	2597
			setupStore	33	5	266	43	49	121
			numNetworkReqs	66	21	186	37	71	170

📊 Page Load Benchmark Results

Current Commit: 4264832 | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±44ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 723ms (±40ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	44ms	1.01s	1.34s	1.06s	1.34s
domContentLoaded	723ms	40ms	697ms	1.00s	736ms	1.00s
firstPaint	76ms	13ms	60ms	196ms	84ms	196ms
firstContentfulPaint	76ms	13ms	60ms	196ms	84ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 23 Bytes (0%)
common: 20 Bytes (0%)

metamaskbotv2 · 2026-01-07T09:21:59Z

Builds ready [4264832]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1311 ± 110 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1311	1014	1688	110	1377	1467
			load	1091	863	1465	102	1167	1229
			domContentLoaded	1085	857	1459	102	1163	1224
			domInteractive	27	15	106	20	23	85
			firstPaint	197	68	1202	207	202	325
			backgroundConnect	222	201	272	11	229	240
			firstReactRender	14	9	31	5	16	28
			getState	36	17	74	11	40	60
			initialActions	1	0	8	1	1	2
			loadScripts	870	658	1243	101	948	1005
			setupStore	13	5	51	6	12	28
			numNetworkReqs	18	11	81	17	11	69
	Browserify	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
	Webpack	Standard Home	uiStartup	806	658	1197	80	858	925
			load	649	585	915	64	669	800
			domContentLoaded	644	580	908	63	662	793
			domInteractive	26	16	148	21	22	80
			firstPaint	106	62	322	55	121	222
			backgroundConnect	25	5	133	30	30	110
			firstReactRender	15	11	35	4	18	24
			getState	34	15	133	20	41	70
			initialActions	1	0	4	1	1	3
			loadScripts	641	578	900	62	659	783
			setupStore	13	7	47	8	14	39
			numNetworkReqs	17	11	73	17	11	69
	Webpack	Power User Home	uiStartup	-	-	-	-	-	-
			load	-	-	-	-	-	-
			domContentLoaded	-	-	-	-	-	-
			domInteractive	-	-	-	-	-	-
			firstPaint	-	-	-	-	-	-
			backgroundConnect	-	-	-	-	-	-
			firstReactRender	-	-	-	-	-	-
			getState	-	-	-	-	-	-
			initialActions	-	-	-	-	-	-
			loadScripts	-	-	-	-	-	-
			setupStore	-	-	-	-	-	-
			numNetworkReqs	-	-	-	-	-	-
Firefox	Browserify	Standard Home	uiStartup	1510	1203	1934	152	1623	1810
			load	1209	1032	1587	111	1264	1426
			domContentLoaded	1209	1026	1587	111	1264	1425
			domInteractive	89	37	242	47	107	209
			firstPaint	-	-	-	-	-	-
			backgroundConnect	72	23	347	57	106	185
			firstReactRender	13	10	22	2	14	18
			getState	14	6	108	16	12	49
			initialActions	1	0	3	1	2	2
			loadScripts	1161	990	1498	88	1218	1328
			setupStore	15	5	200	21	13	45
			numNetworkReqs	21	9	86	21	15	83
	Browserify	Power User Home	uiStartup	2562	1488	3555	541	3018	3206
			load	1765	1015	2741	534	2253	2479
			domContentLoaded	1765	1015	2741	534	2252	2479
			domInteractive	90	33	919	110	85	298
			firstPaint	-	-	-	-	-	-
			backgroundConnect	356	20	1335	359	451	1097
			firstReactRender	19	12	62	7	23	28
			getState	101	65	293	32	118	155
			initialActions	2	0	7	1	2	3
			loadScripts	1515	996	2568	467	2001	2302
			setupStore	62	5	1017	146	69	208
			numNetworkReqs	69	30	176	32	78	159
	Webpack	Standard Home	uiStartup	1512	1254	1961	161	1575	1873
			load	1282	1089	1538	100	1333	1477
			domContentLoaded	1281	1089	1538	100	1333	1476
			domInteractive	77	27	181	37	102	132
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	17	204	34	59	124
			firstReactRender	14	10	44	4	15	21
			getState	15	7	206	22	14	45
			initialActions	1	0	4	1	2	2
			loadScripts	1248	1076	1497	93	1304	1432
			setupStore	16	4	138	22	14	50
			numNetworkReqs	19	9	85	19	13	77
	Webpack	Power User Home	uiStartup	2683	1652	3399	539	3118	3337
			load	2026	1096	2767	533	2486	2690
			domContentLoaded	2026	1096	2767	534	2486	2690
			domInteractive	73	29	1041	110	66	161
			firstPaint	-	-	-	-	-	-
			backgroundConnect	337	26	1165	351	408	1083
			firstReactRender	20	13	154	15	22	31
			getState	96	62	235	31	102	168
			initialActions	2	0	3	1	2	2
			loadScripts	1774	1081	2744	463	2219	2597
			setupStore	33	5	266	43	49	121
			numNetworkReqs	66	21	186	37	71	170

📊 Page Load Benchmark Results

Current Commit: 4264832 | Date: 1/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±44ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 723ms (±40ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	44ms	1.01s	1.34s	1.06s	1.34s
domContentLoaded	723ms	40ms	697ms	1.00s	736ms	1.00s
firstPaint	76ms	13ms	60ms	196ms	84ms	196ms
firstContentfulPaint	76ms	13ms	60ms	196ms	84ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 23 Bytes (0%)
common: 20 Bytes (0%)

GuillaumeRx had a problem deploying to pr-comment January 6, 2026 14:50 — with GitHub Actions Error

metamaskbot added the team-core-platform Core Platform team label Jan 6, 2026

GuillaumeRx temporarily deployed to pr-comment January 6, 2026 14:50 — with GitHub Actions Inactive

github-actions bot added the size-S label Jan 6, 2026

GuillaumeRx added 3 commits January 6, 2026 16:11

fix MenuItem info dot

433311d

remove hardcoded value

4019848

fix position

4264832

GuillaumeRx force-pushed the gr/fix-notification-dot branch from 690d644 to 4264832 Compare January 6, 2026 15:11

GuillaumeRx temporarily deployed to pr-comment January 6, 2026 15:11 — with GitHub Actions Inactive

FrederikBolding approved these changes Jan 6, 2026

View reviewed changes

GuillaumeRx temporarily deployed to pr-comment January 6, 2026 15:41 — with GitHub Actions Inactive

FrederikBolding requested a review from Mrtenz January 7, 2026 08:47

Mrtenz approved these changes Jan 7, 2026

View reviewed changes

GuillaumeRx temporarily deployed to pr-comment January 7, 2026 09:17 — with GitHub Actions Inactive

GuillaumeRx added this pull request to the merge queue Jan 7, 2026

Merged via the queue into main with commit 19da8a3 Jan 7, 2026
331 of 335 checks passed

GuillaumeRx deleted the gr/fix-notification-dot branch January 7, 2026 10:26

github-actions bot locked and limited conversation to collaborators Jan 7, 2026

metamaskbot added the release-13.14.0 Issue or pull request that will be included in release 13.14.0 label Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Update `MenuItem` info dot #39042

fix: Update `MenuItem` info dot #39042

GuillaumeRx commented Jan 6, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

metamaskbotv2 bot commented Jan 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: Update MenuItem info dot #39042

fix: Update MenuItem info dot #39042

Conversation

GuillaumeRx commented Jan 6, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

metamaskbotv2 bot commented Jan 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Jan 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: Update `MenuItem` info dot #39042

fix: Update `MenuItem` info dot #39042

GuillaumeRx commented Jan 6, 2026 •

edited by cursor bot

Loading