Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 26, 2025

Note

Expands and standardizes localization for the Snap UI.

  • Adds new locale files: de_DE, el_GR, en_GB, fr_FR, hi_IN, id_ID, ja_JP, ko_KR, pt_BR, ru_RU, tl_PH, tr_TR, vi_VN
  • Updates es_419.json (locale set to es, minor copy tweaks, adds error.3100)
  • Extends zh_CN.json with standardized error.* keys for parity with other locales
  • Ensures common UI strings (send/confirm/review, address validation, amount errors) are present across locales

Written by Cursor Bugbot for commit 6870d77. This will update automatically on new commits. Configure here.

@github-actions github-actions bot requested a review from a team as a code owner August 26, 2025 13:44
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from fa831d7 to 8bf31a0 Compare August 26, 2025 16:30
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 11 times, most recently from 0485788 to dce42f2 Compare August 31, 2025 00:22
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 14 times, most recently from 2cdaccc to 9714208 Compare September 7, 2025 00:21
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Japanese locale file has wrong locale identifier

The Japanese locale file ja_JP.json has "locale": "en" instead of "locale": "ja". This mismatch could cause the application to incorrectly identify this file as English content, potentially breaking locale detection or language selection for Japanese users. All other locale files in this PR correctly use their respective language codes (e.g., de_DE.json uses "locale": "de", ko_KR.json uses "locale": "ko").

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 4197359 to 55db8a2 Compare December 18, 2025 12:09
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Japanese locale file has wrong locale identifier

The ja_JP.json file incorrectly sets "locale": "en" instead of "locale": "ja". The file contains Japanese translations (as evidenced by messages like "進める前にトランザクションを確認してください"), but the locale identifier marks it as English. This will cause the localization system to misidentify this file, preventing Japanese users from seeing the correct translations.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 55db8a2 to a1c56ed Compare December 19, 2025 00:23
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Japanese locale file has wrong locale identifier

The ja_JP.json file sets "locale": "en" instead of "locale": "ja". This mismatch causes the Japanese translation file to incorrectly identify itself as English. When the localization system loads this file for Japanese users, it may not properly recognize it as Japanese content, potentially causing fallback behavior or incorrect locale matching. The existing ja.json correctly uses "locale": "ja".

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 4d4074c to 6000726 Compare December 20, 2025 00:22
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Japanese locale file has incorrect locale identifier

The ja_JP.json file has "locale": "en" instead of "locale": "ja". The existing ja.json file correctly uses "locale": "ja". This mismatch could cause the localization system to treat Japanese translations as English, resulting in Japanese users not seeing the correct translations or experiencing locale resolution issues.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 8912c78 to 0244c4e Compare December 21, 2025 00:24
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Japanese locale file has wrong locale identifier

The locale field in ja_JP.json is set to "en" but it contains Japanese translations and should be "ja". The existing ja.json file correctly uses "locale": "ja". This mismatch will cause the localization system to incorrectly identify the Japanese locale file as English, potentially breaking locale detection and fallback behavior for Japanese users.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 0244c4e to bd243e5 Compare December 21, 2025 12:08
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Japanese locale file incorrectly identifies as English

The locale field in ja_JP.json is set to "en" instead of "ja". The existing ja.json correctly uses "locale": "ja", but this new regional variant file incorrectly declares itself as English. This would cause the localization system to misidentify these Japanese translations as English, potentially preventing Japanese users from seeing their localized content.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 3 times, most recently from 53e5f07 to d952502 Compare December 23, 2025 00:22
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Japanese locale file incorrectly identifies as English

The locale field in ja_JP.json is set to "en" instead of "ja". This Japanese translation file contains proper Japanese text in the messages but identifies itself as English, which would cause the localization system to not correctly apply Japanese translations for users with that locale. Other locale files (like ja.json) correctly use "ja" for the locale value.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 86e1699 to 4b6ee50 Compare December 24, 2025 00:22
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Japanese locale file declares incorrect locale value

The ja_JP.json file declares "locale": "en" but contains Japanese translations. This mismatch will likely cause the localization system to incorrectly identify this file as English content, preventing Japanese users from seeing proper Japanese translations. The locale value needs to be "ja" to match the actual content of the file, consistent with the existing ja.json file which correctly uses "locale": "ja".

Fix in Cursor Fix in Web

@@ -1,5 +1,5 @@
{
"locale": "es_419",
"locale": "es",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate locale identifier after changing Spanish locale

The PR changes the locale value in es_419.json from "es_419" to "es", but es.json already declares "locale": "es". This creates two different locale files with identical locale identifiers. The localization system may behave unpredictably when two files claim the same locale, potentially ignoring one file or causing inconsistent locale resolution. Latin American Spanish (es_419) was a distinct locale variant that is now lost.

Fix in Cursor Fix in Web

@@ -0,0 +1,218 @@
{
"locale": "pt-BR",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Portuguese file duplicates existing locale identifier

The newly added pt_BR.json file declares "locale": "pt-BR", but the existing pt.json file already uses the same "locale": "pt-BR" value. Having two distinct locale files with identical locale identifiers could cause unpredictable behavior in the localization system, where one file may be ignored or loaded inconsistently.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 4b6ee50 to 3201bac Compare December 24, 2025 12:09
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Japanese locale file has incorrect locale identifier

The ja_JP.json locale file has "locale": "en" but contains Japanese translations. This mismatch means the localization system will likely treat this file as English rather than Japanese, causing Japanese users to potentially receive incorrect locale handling or fallback behavior. The value should be "ja" to match the existing ja.json file pattern.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from fdca254 to 73cc4e6 Compare December 25, 2025 12:09
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Japanese locale file has wrong locale identifier

The locale field in ja_JP.json is set to "en" but this file contains Japanese translations and represents the Japanese locale. Comparing to the existing ja.json which correctly has "locale": "ja", this appears to be a mistake in the translation import. This mismatch could cause locale-specific formatting (dates, numbers) to use English conventions instead of Japanese, or affect language detection and fallback behavior for Japanese users.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 73cc4e6 to 13de552 Compare December 26, 2025 00:22
@@ -0,0 +1,218 @@
{
"locale": "en",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Japanese locale file has incorrect locale identifier

The ja_JP.json locale file has "locale": "en" instead of "locale": "ja". This mismatch between the file content (Japanese translations) and the locale identifier could cause the application to incorrectly identify or process this locale, potentially leading to localization issues for Japanese users.

Fix in Cursor Fix in Web

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 13de552 to 6870d77 Compare December 26, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants