-
-
Notifications
You must be signed in to change notification settings - Fork 6
New Crowdin translations by Github Action #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fa831d7 to
8bf31a0
Compare
0485788 to
dce42f2
Compare
2cdaccc to
9714208
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Japanese locale file has wrong locale identifier
The Japanese locale file ja_JP.json has "locale": "en" instead of "locale": "ja". This mismatch could cause the application to incorrectly identify this file as English content, potentially breaking locale detection or language selection for Japanese users. All other locale files in this PR correctly use their respective language codes (e.g., de_DE.json uses "locale": "de", ko_KR.json uses "locale": "ko").
4197359 to
55db8a2
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Japanese locale file has wrong locale identifier
The ja_JP.json file incorrectly sets "locale": "en" instead of "locale": "ja". The file contains Japanese translations (as evidenced by messages like "進める前にトランザクションを確認してください"), but the locale identifier marks it as English. This will cause the localization system to misidentify this file, preventing Japanese users from seeing the correct translations.
55db8a2 to
a1c56ed
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Japanese locale file has wrong locale identifier
The ja_JP.json file sets "locale": "en" instead of "locale": "ja". This mismatch causes the Japanese translation file to incorrectly identify itself as English. When the localization system loads this file for Japanese users, it may not properly recognize it as Japanese content, potentially causing fallback behavior or incorrect locale matching. The existing ja.json correctly uses "locale": "ja".
4d4074c to
6000726
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file has incorrect locale identifier
The ja_JP.json file has "locale": "en" instead of "locale": "ja". The existing ja.json file correctly uses "locale": "ja". This mismatch could cause the localization system to treat Japanese translations as English, resulting in Japanese users not seeing the correct translations or experiencing locale resolution issues.
8912c78 to
0244c4e
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file has wrong locale identifier
The locale field in ja_JP.json is set to "en" but it contains Japanese translations and should be "ja". The existing ja.json file correctly uses "locale": "ja". This mismatch will cause the localization system to incorrectly identify the Japanese locale file as English, potentially breaking locale detection and fallback behavior for Japanese users.
0244c4e to
bd243e5
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file incorrectly identifies as English
The locale field in ja_JP.json is set to "en" instead of "ja". The existing ja.json correctly uses "locale": "ja", but this new regional variant file incorrectly declares itself as English. This would cause the localization system to misidentify these Japanese translations as English, potentially preventing Japanese users from seeing their localized content.
53e5f07 to
d952502
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file incorrectly identifies as English
The locale field in ja_JP.json is set to "en" instead of "ja". This Japanese translation file contains proper Japanese text in the messages but identifies itself as English, which would cause the localization system to not correctly apply Japanese translations for users with that locale. Other locale files (like ja.json) correctly use "ja" for the locale value.
86e1699 to
4b6ee50
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file declares incorrect locale value
The ja_JP.json file declares "locale": "en" but contains Japanese translations. This mismatch will likely cause the localization system to incorrectly identify this file as English content, preventing Japanese users from seeing proper Japanese translations. The locale value needs to be "ja" to match the actual content of the file, consistent with the existing ja.json file which correctly uses "locale": "ja".
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "locale": "es_419", | |||
| "locale": "es", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate locale identifier after changing Spanish locale
The PR changes the locale value in es_419.json from "es_419" to "es", but es.json already declares "locale": "es". This creates two different locale files with identical locale identifiers. The localization system may behave unpredictably when two files claim the same locale, potentially ignoring one file or causing inconsistent locale resolution. Latin American Spanish (es_419) was a distinct locale variant that is now lost.
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "pt-BR", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New Portuguese file duplicates existing locale identifier
The newly added pt_BR.json file declares "locale": "pt-BR", but the existing pt.json file already uses the same "locale": "pt-BR" value. Having two distinct locale files with identical locale identifiers could cause unpredictable behavior in the localization system, where one file may be ignored or loaded inconsistently.
4b6ee50 to
3201bac
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file has incorrect locale identifier
The ja_JP.json locale file has "locale": "en" but contains Japanese translations. This mismatch means the localization system will likely treat this file as English rather than Japanese, causing Japanese users to potentially receive incorrect locale handling or fallback behavior. The value should be "ja" to match the existing ja.json file pattern.
fdca254 to
73cc4e6
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file has wrong locale identifier
The locale field in ja_JP.json is set to "en" but this file contains Japanese translations and represents the Japanese locale. Comparing to the existing ja.json which correctly has "locale": "ja", this appears to be a mistake in the translation import. This mismatch could cause locale-specific formatting (dates, numbers) to use English conventions instead of Japanese, or affect language detection and fallback behavior for Japanese users.
73cc4e6 to
13de552
Compare
| @@ -0,0 +1,218 @@ | |||
| { | |||
| "locale": "en", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japanese locale file has incorrect locale identifier
The ja_JP.json locale file has "locale": "en" instead of "locale": "ja". This mismatch between the file content (Japanese translations) and the locale identifier could cause the application to incorrectly identify or process this locale, potentially leading to localization issues for Japanese users.
13de552 to
6870d77
Compare
Note
Expands and standardizes localization for the Snap UI.
de_DE,el_GR,en_GB,fr_FR,hi_IN,id_ID,ja_JP,ko_KR,pt_BR,ru_RU,tl_PH,tr_TR,vi_VNes_419.json(locale set toes, minor copy tweaks, addserror.3100)zh_CN.jsonwith standardizederror.*keys for parity with other localesWritten by Cursor Bugbot for commit 6870d77. This will update automatically on new commits. Configure here.