Forward peer dependencies to consumers #357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/json-rpc-engine@10.0.0, npm/@metamask/rpc-errors@7.0.0, npm/escalade@3.1.2 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Contributor
Author
|
@SocketSecurity ignore npm/@metamask/snaps-utils@8.6.0 This is OK. This is our package. |
mcmire
force-pushed
the
forward-peer-dependencies
branch
from
5469cf8 to
ca14288
Compare
Some controller dependencies of this package have peer dependencies, but those additional dependencies are not present in this package's manifest, and as a result peer dependency warnings are being generated at install time: ``` warning " > @metamask/accounts-controller@18.2.3" has unmet peer dependency "@metamask/snaps-controllers@^9.7.0". warning "@metamask/accounts-controller > @metamask/keyring-api@8.1.3" has unmet peer dependency "@metamask/providers@^17.2.0". warning "@metamask/accounts-controller > @metamask/snaps-sdk > @metamask/providers@18.1.1" has unmet peer dependency "webextension-polyfill@^0.10.0 || ^0.11.0 || ^0.12.0". warning "@metamask/accounts-controller > @metamask/snaps-sdk > @metamask/providers > extension-port-stream@4.2.0" has unmet peer dependency "webextension-polyfill@^0.10.0 || ^0.11.0 || ^0.12.0". warning " > @metamask/eslint-config-typescript@12.1.0" has incorrect peer dependency "typescript@~4.8.4 || ~5.0 || ~5.1". warning " > @metamask/transaction-controller@37.3.0" has incorrect peer dependency "@metamask/gas-fee-controller@^20.0.0". warning "@metamask/transaction-controller > @metamask/nonce-tracker@6.0.0" has unmet peer dependency "@metamask/eth-block-tracker@>=9". ``` While adding the required dependencies directly to the `dependencies` section would make the warnings disappear, it would be more useful for the clients to have them. This commit denotes this need by adding them to `peerDependencies` instead. After making these changes, there are only a couple peer dependency warnings left: ``` warning " > @lavamoat/allow-scripts@3.2.0" has unmet peer dependency "@lavamoat/preinstall-always-fail@*". warning " > @metamask/eslint-config-typescript@12.1.0" has incorrect peer dependency "typescript@~4.8.4 || ~5.0 || ~5.1". warning " > @metamask/transaction-controller@37.3.0" has incorrect peer dependency "@metamask/gas-fee-controller@^20.0.0". ``` The remaining peer dependency warnings will be addressed in future commits.
mcmire
force-pushed
the
forward-peer-dependencies
branch
from
ca14288 to
6147221
Compare
Contributor
Author
|
Partially superceded by #360. |
Contributor
Author
|
Now obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some controller dependencies of this package have peer dependencies, but those additional dependencies are not present in this package's manifest, and as a result peer dependency warnings are being generated at install time:
While adding the required dependencies directly to the
dependenciessection would make the warnings disappear, it would be more useful for the clients to have them. This commit denotes this need by adding them topeerDependenciesinstead.After making these changes, there are only a couple peer dependency warnings left:
The remaining peer dependency warnings will be addressed in future commits.