Skip to content

chore: MMConnect Configuration Improvements#91

Merged
wenfix merged 5 commits intomainfrom
ad/modify-mm-connect-implementation
Nov 27, 2025
Merged

chore: MMConnect Configuration Improvements#91
wenfix merged 5 commits intomainfrom
ad/modify-mm-connect-implementation

Conversation

@adonesky1
Copy link
Collaborator

@adonesky1 adonesky1 commented Nov 26, 2025

Makes improvements to MM Connect configurability and testabilty

  • Scope selection for MMConnect: Auto Connect via MM Connect now passes selected scopes from checkboxes instead of hardcoding ['eip155:1'].
  • Network checkboxes: Removed disabled attribute so scopes can be selected before connecting.
  • Supported networks configuration: Added RPC URLs for all featured networks (Ethereum, Linea, Arbitrum, Avalanche, BNB, Optimism, Polygon, zkSync, Base, Localhost, Solana) in MetaMaskConnectProvider.
  • Disconnect button: Added red "Disconnect MMConnect Session" button that appears when a MMConnect session is active.

This enables users to select desired scopes via checkboxes before auto-connecting via MMConnect, improving the test dapp's flexibility for multi-chain testing.


Note

Enables scope-selectable MM Connect auto-connect, configures supported networks, and adds a session disconnect button.

  • UI (App.tsx):
    • Auto Connect via MM_CONNECT_ID now passes selected scopes from checkboxes/custom inputs.
    • Network checkboxes enabled for pre-connection scope selection.
    • Shows red "Disconnect MMConnect Session" button when an MM Connect session is active.
  • SDK:
    • SDK.setExtensionIdAndConnect accepts optional scopes: CaipChainId[] and forwards to provider for MM Connect.
    • useSDK.connect signature updated to accept optional scopes and propagate to SDK.
  • MetaMaskConnectProvider:
    • connect(scopes?: Scope[]) accepts scopes; defaults to ['eip155:1'] when none provided.
    • Adds supportedNetworks RPC URLs for featured chains (Ethereum, Linea, Arbitrum, Avalanche, BNB, OP, Polygon, zkSync, Base, Localhost, Solana).

Written by Cursor Bugbot for commit 243190e. This will update automatically on new commits. Configure here.

@adonesky1 adonesky1 requested a review from a team as a code owner November 26, 2025 19:46
@adonesky1 adonesky1 changed the title Ad/modify mm connect implementation MMConnect Configuration Improvements Nov 26, 2025
@adonesky1 adonesky1 changed the title MMConnect Configuration Improvements chore: MMConnect Configuration Improvements Nov 26, 2025
Base automatically changed from ad/update-mm-connect-version to main November 27, 2025 08:51
@ffmcgee725 ffmcgee725 requested a review from a team as a code owner November 27, 2025 08:51
@wenfix wenfix merged commit 88bd7f5 into main Nov 27, 2025
15 checks passed
@wenfix wenfix deleted the ad/modify-mm-connect-implementation branch November 27, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants