added novaFurryXL_ilV140 #20
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the model name from "novaFurryXL_V8B" to "novaFurryXL_ilV140" across the options component to reflect a model version change.
Key Changes:
- Updated model selection dropdown to display the new model name
- Updated model name references in the TypeScript component for CFG scale logic and aspect ratio configurations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/home/options/options.component.html | Updated the model dropdown option value and display text to "novaFurryXL_ilV140" |
| src/app/home/options/options.component.ts | Updated model name in the changeModel() method for CFG scale logic and in the changeAspectRatio() method for all aspect ratio configurations |
Note: During the review, I identified that there is an inconsistency in the codebase. The models_types object at line 42 of src/app/home/options/options.component.ts still contains the old model name "novaFurryXL_V8B" which should be updated to "novaFurryXL_ilV140". This object is used by the updateCreditCost() method to determine the model type for credit calculations. However, this line is outside the changed regions in this PR, so I cannot create a formal comment on it. I recommend updating this in a follow-up commit or ensuring it's addressed before merging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.