Theme option, prevent flash of wrong system theme and other changes#40
Open
will-lol wants to merge 7 commits intoMethodGrab:masterfrom
Open
Theme option, prevent flash of wrong system theme and other changes#40will-lol wants to merge 7 commits intoMethodGrab:masterfrom
will-lol wants to merge 7 commits intoMethodGrab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add theme option
I added an option that uses the theme.getCurrent() API to match the background of the tab before loading to that of the current theme.
Prevent flash of wrong system theme
When the system was in dark mode, the previous behavior would flash a white page before loading the page. Now the body color matches that of the default Firefox light and dark themes depending on the prefers-color-scheme media query. This does not override a custom color that may be set, it only applies to the 'none' setting.
Additional changes
I changed the light and dark colors to match that of the default Firefox light and dark themes.