Better schematic spawning #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data. Now we do.
Author
|
This has problem how the current MER works when loading only with data it can't be saved properly, because iirc data are not saved, but only the name of schematic. For spawning great, but for saving horrible. How can we fix this problem? Check the data if there is no Schematic named as it was spawned then you will continue and won't save. If the schematic exists, but you do GetDataBySchematicName() and it's not equal the same then it will also not save and continue. It's not that big of an issue tbh. |
|
Ngl this is a duplicate PR kek, math already made a PR for this, you at least dont use stinky _lowerCamelCase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can easily spawn schematics with data. How hard was that? Not at all implemented it under 5 min (not counting that I had to add every fucking dependency under the sun).