Gen6 additions #360
Merged
Gen6 additions #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsgunth
reviewed
Dec 5, 2025
Collaborator
lsgunth
left a comment
lsgunth
left a comment
There was a problem hiding this comment.
A couple interface issues to consider.
Lots of minor white-space, tabbing and code formatting issues.
The majority of the PR looks sound.
Add PSX/PFX device ids for gen6, add gen6 device decode functions and version decode functions. Gen6 lane info and link info added.
BenReed161
force-pushed
the
gen6-additions
branch
5 times, most recently
from
39b9a69 to
c10905d
Compare
Add RTC command to switchtec user for gen6 switchtec. Can set, get, reset the RTC. Add RTC MRPC command ID. and MRPC sub commands for RTC
BenReed161
force-pushed
the
gen6-additions
branch
4 times, most recently
from
84ce40d to
61fbf0c
Compare
kelvin-cao
reviewed
Dec 9, 2025
kelvin-cao
reviewed
Dec 9, 2025
| return 0; | ||
| } | ||
|
|
||
| int security_settings_get_gen6(struct switchtec_dev *dev, |
Collaborator
There was a problem hiding this comment.
If it's BL1 only, maybe can use some comments to explain.
kelvin-cao
reviewed
Dec 9, 2025
lsgunth
approved these changes
Dec 10, 2025
Collaborator
lsgunth
left a comment
lsgunth
left a comment
There was a problem hiding this comment.
I'm still seeing a hand full of whitespace issues. This is minor.
Besides that, I approve.
BenReed161
force-pushed
the
gen6-additions
branch
4 times, most recently
from
cbbc22a to
855d192
Compare
Add gen6 metadata and firmware partition types and flash info structures. Update the gen6 get firmware partition functions with Gen6 flash info structures. Add MRPC fw part command ids for gen6.
Gen6 does not have RIOT core partition
Add the updated command ids for mfg MRPC command calls for gen6. Update the gen5 mfg calls to 56 which will account for both cases, gen5/gen6. Bootresume is not supported in gen6 add check in boot_resume command.
BenReed161
force-pushed
the
gen6-additions
branch
from
855d192 to
44c4592
Compare
Add pipe datapath type for gen6. New loopback type and update function names which previosly called gen5 to gen56 since they support both now
Add MRPC PATGEN / MON subcommands ids and checks to functions
Add Gen6 and Gen6 Speed to LTSSM command
Add case for switchtec gen6 which uses same gen4 hdr write function
Added check for Gen6 and change to gen6 command id OSA
Compilation issue for declaration after label in some situations, moved array declaration to top of function block instead.
Add Gen6 function fw img get command read command to the existing fw-read command
Add new gen6 function to handle gen6 log dumping. Add gen6 log output structure and handling string function to decode the values sent from the log dum p MRPC.
Add check for running new security settings for the OTPs in BL1 stage of the boot. Add check in the info command Add new OTP MRPC get command as part of secure mfg settings.
BenReed161
force-pushed
the
gen6-additions
branch
from
44c4592 to
cc26005
Compare
kelvin-cao
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands updated / supported with the Gen6 spec
• info
• log-dump
• log-parse
• test
• temp
• hard-reset
• fw-update
• fw-info
• fw-redundant
• fw-read
• fw-img-info
• rtc
• mfg ping
• mfg info
• mfg mailbox
• mfg fw-transfer
• mfg fw-execute