Skip to content

Conversation

@moematsuo
Copy link
Contributor

No description provided.

@prmerger-automator
Copy link
Contributor

@moematsuo : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 590d178:

✅ Validation status: passed

File Status Preview URL Details
docs/tools/configuration-manager/sql-server-properties-advanced-tab.md ✅Succeeded

For more details, please refer to the build report.

@ktoliver ktoliver requested a review from Copilot October 30, 2025 15:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the "Lock Pages In Memory" configuration option in SQL Server Configuration Manager's advanced tab. This setting controls memory privileges for the SQL Server Database Engine Service Account.

Key Changes:

  • Added documentation entry for the Lock Pages In Memory configuration option

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.



**Lock Pages In Memory**
Grant Lock Pages In Memory privilege to SQL Server Database Engine Service Account (Newer than SQL Server 2019).
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Replace 'Newer than' with 'Available in' or 'Introduced in' for more professional documentation language.

Suggested change
Grant Lock Pages In Memory privilege to SQL Server Database Engine Service Account (Newer than SQL Server 2019).
Grant Lock Pages In Memory privilege to SQL Server Database Engine Service Account (Available in SQL Server 2022 and later).

Copilot uses AI. Check for mistakes.


**Lock Pages In Memory**
Grant Lock Pages In Memory privilege to SQL Server Database Engine Service Account (Newer than SQL Server 2019).
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version information is unclear. Specify whether this applies to SQL Server 2019 and later (>=2019) or only to versions after 2019 (>2019). Also clarify if 'SQL Server 2019' refers to a specific version number (e.g., SQL Server 2019 CU1) or the base version.

Suggested change
Grant Lock Pages In Memory privilege to SQL Server Database Engine Service Account (Newer than SQL Server 2019).
Grants the Lock Pages In Memory privilege to the SQL Server Database Engine Service Account (available in SQL Server 2019 (base version) and later).

Copilot uses AI. Check for mistakes.
@ktoliver
Copy link
Contributor

@rwestMSFT

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants