Skip to content

Conversation

@FladoToo
Copy link
Contributor

@FladoToo FladoToo commented Jan 5, 2026

The current syntax description does not allow specifying index rebuild options without including a PARTITION clause. Both the examples on this page (e.g.
ALTER INDEX IX_INDEX1 ON T1 REBUILD WITH (DATA_COMPRESSION = PAGE); GO
) and elsewhere, and actual testing in SQL Server 2022 show that the proposed syntax works and is actually supported.

The current syntax description does not allow specifying index rebuild options without including a PARTITION clause. Both the examples on this page and elsewhere and actual testing in SQL Server 2022 show that the proposed syntax works and is actually supported.
@prmerger-automator
Copy link
Contributor

@FladoToo : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 269f2ce:

✅ Validation status: passed

File Status Preview URL Details
docs/t-sql/statements/alter-index-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

@dimitri-furman
Copy link
Contributor

@FladoToo thanks for finding this problem.

Please also change the curly brackets after REBUILD to square brackets to indicate that index rebuild options are optional, i.e.:

      REBUILD [
            [ WITH ( <rebuild_index_option> [ , ...n ] ) ]
          | [ PARTITION = ALL [ WITH ( <rebuild_index_option> [ , ...n ] ) ] ]
          | [ PARTITION = partition_number [ WITH ( <single_partition_rebuild_index_option> [ , ...n ] ) ] ]
      ]

Implementing the change suggested by the reviewer @dimitri-furman
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 7d80833:

✅ Validation status: passed

File Status Preview URL Details
docs/t-sql/statements/alter-index-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

Updated the review team and modified the date.
@WilliamDAssafMSFT
Copy link
Contributor

Thanks @FladoToo for taking the time to submit this PR! Good catch.

After you confirm the CLA, your commit will be merged and this article update is in flight. After the updated article is published, GitHub will list you as an article contributor.

Thanks again for this feedback, your suggestions help improve our documentation.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 1e3d5b6:

✅ Validation status: passed

File Status Preview URL Details
docs/t-sql/statements/alter-index-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards
Copy link
Contributor

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jan 5, 2026
@FladoToo
Copy link
Contributor Author

FladoToo commented Jan 7, 2026

I did this in the course of a contract so it is my customer who owns any IP. However, I have no right to agree to the CLA on their behalf yet - I asked them for authorization, and will get back to you when I hear from them. Sorry, I didn't think it would be that complicated.

@WilliamDAssafMSFT
Copy link
Contributor

@FladoToo I understand, in this case, the "code" is limited to the TSQL syntax in this PR, and not any other code. This is a blanket requirement for public contributions to Microsoft Open Source docs that prevents us from inadvertently publishing owned content. I think you're good to go here.

@WilliamDAssafMSFT
Copy link
Contributor

This has conflicted with an internal PR. I'm going to take this commit internally and resolve internally. Your commit will be merged and this article update is in flight. After the updated article is published, GitHub will list you as an article contributor.

#please-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants