-
Couldn't load subscription status.
- Fork 62
Add specs for AcceleratorKeyPressed event args extension APIs #3861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tofuandeve
wants to merge
7
commits into
main
Choose a base branch
from
api-accelerator-key-pressed-event-args-extension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
42cc466
Add specs for AcceleratorKeyPressed event args extension
25162ea
Address comments
3168310
Merge pull request #3838 from MicrosoftEdge/api-accelerator-key-press…
tofuandeve d9641d2
address comments
7c2596b
indentation
76b709a
Update docs
7402124
Addess comments about specs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| # Background | ||
| WebView2 has `ICoreWebView2AcceleratorKeyPressedEventArgs` for the `AcceleratorKeyPressed` event. We have been asked to extend this API so that developers can indicate that they would like an existing browser accelerator key to be disabled as a browser accelerator. | ||
|
|
||
| In this document we describe the updated API. We'd appreciate your feedback. | ||
|
|
||
| # Description | ||
| We propose extending the `ICoreWebView2AcceleratorKeyPressedEventArgs` to allow developers to enable/disable the browser from handling accelerator keys with `AllowBrowserHandle` property. | ||
|
|
||
| # Examples | ||
| ## C++ | ||
|
|
||
| ``` cpp | ||
| EventRegistrationToken m_acceleratorKeyPressedToken = {}; | ||
|
|
||
| wil::com_ptr<ICoreWebView2Controller> m_controller; | ||
| wil::com_ptr<ICoreWebView2> m_webView; | ||
| wil::com_ptr<ICoreWebView2Settings3> m_settings3; | ||
|
|
||
| { | ||
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| wil::com_ptr<ICoreWebView2Settings> settings; | ||
| CHECK_FAILURE(m_webView->get_Settings(&settings)); | ||
| m_settings3 = settings.try_query<ICoreWebView2Settings3>(); | ||
| if (m_setting3) | ||
| { | ||
| // Disable all browser accelerator keys | ||
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| CHECK_FAILURE(m_settings3->put_AreBrowserAcceleratorKeysEnabled(FALSE)); | ||
| // Register a handler for the AcceleratorKeyPressed event. | ||
| CHECK_FAILURE(m_controller->add_AcceleratorKeyPressed( | ||
| Callback<ICoreWebView2AcceleratorKeyPressedEventHandler>( | ||
| [this]( | ||
| ICoreWebView2Controller* sender, | ||
| ICoreWebView2AcceleratorKeyPressedEventArgs* args) -> HRESULT | ||
| { | ||
| COREWEBVIEW2_KEY_EVENT_KIND kind; | ||
| CHECK_FAILURE(args->get_KeyEventKind(&kind)); | ||
| // We only care about key down events. | ||
tofuandeve marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if (kind == COREWEBVIEW2_KEY_EVENT_KIND_KEY_DOWN || | ||
| kind == COREWEBVIEW2_KEY_EVENT_KIND_SYSTEM_KEY_DOWN) | ||
| { | ||
| UINT key; | ||
| CHECK_FAILURE(args->get_VirtualKey(&key)); | ||
|
|
||
| wil::com_ptr<ICoreWebView2AcceleratorKeyPressedEventArgs2> | ||
| args2; | ||
|
|
||
| CHECK_FAILURE(args->QueryInterface(IID_PPV_ARGS(&args2))); | ||
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if (key == VK_F7) | ||
| { | ||
| // Allow the browser to process F7 key | ||
| CHECK_FAILURE(args2->put_AllowBrowserHandle(TRUE)); | ||
| } | ||
| } | ||
| return S_OK; | ||
| }) | ||
| .Get(), | ||
| &m_acceleratorKeyPressedToken)); | ||
|
|
||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ## C# | ||
| ```c# | ||
| CoreWebView2Settings _webViewSettings = webView.CoreWebView2.Settings; | ||
| // All browser accelerator keys are disabled with this setting | ||
| _webViewSettings.AreBrowserAcceleratorKeysEnabled = false; | ||
|
|
||
| webView.CoreWebView2.AcceleratorKeyPressed += WebView2Controller_AcceleratorKeyPressed; | ||
|
|
||
| void WebView2Controller_AcceleratorKeyPressed(object sender, CoreWebView2AcceleratorKeyPressedEventArgs e) | ||
| { | ||
| switch (e.KeyEventKind) | ||
| { | ||
| case CoreWebView2KeyEventKind.KeyDown: | ||
| case CoreWebView2KeyEventKind.SystemKeyDown: | ||
| { | ||
| Keys keyData = (Keys)(e.VirtualKey); | ||
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| // Allow the browser to process F7 key | ||
| if (e.VirtualKey == Key.F7) | ||
| { | ||
| e.AllowBrowserHandle = true; | ||
| } | ||
| break; | ||
| } | ||
|
|
||
| } | ||
| } | ||
|
|
||
| ``` | ||
|
|
||
| # Remarks | ||
| By default, `AreBrowserAcceleratorKeyEnabled` is `TRUE` and default value for `AllowBrowserHandle` is `TRUE`. When developers set `AreBrowserAcceleratorKeyEnabled` to `FALSE` this will also change the default value for `AllowBrowserHandle` to `FALSE`. If developers want specific keys to be handled by the browser after changing the `AreBrowserAcceleratorKeyEnabled` settings to `FALSE`, they need to enable them by setting `event_args->put_ AllowBrowserHandle(TRUE)`. This option will give the event arg higher priority over the settings when the browser decide whether to handle the keys. | ||
|
|
||
| # API Details | ||
| ## C++ | ||
| ``` | ||
| /// This is a continuation of the ICoreWebView2AcceleratorKeyPressedEventArgs interface. | ||
| [uuid(45238725-3774-4cfe-931f-7985a1b5866f), object, pointer_default(unique)] | ||
| interface ICoreWebView2AcceleratorKeyPressedEventArgs2 : ICoreWebView2AcceleratorKeyPressedEventArgs { | ||
| /// These APIs allow devs to enable/disable the browser from handling specific accelerator keys. | ||
| /// By default, `AreBrowserAcceleratorKeyEnabled` is `TRUE` and `AllowBrowserHandle` is `TRUE`. | ||
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| /// When devs set `AreBrowserAcceleratorKeyEnabled` to `FALSE` this will override and the | ||
| /// default value for `AllowBrowserHandle` will be `FALSE` and prevent the browser to handle | ||
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| /// accelerator keys. If users want specific keys to be handled by the browser after changing | ||
| /// the settings to `FALSE`, they need to enable them by setting `AllowBrowserHandle` to `TRUE`. | ||
| /// This option will give the event arg higher priority over the `AreBrowserAcceleratorKeyEnabled` | ||
| /// settings when we handle the keys. | ||
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| /// | ||
| /// \snippet ScenarioAcceleratorKeyPressed.cpp | ||
| /// Gets the `AllowBrowserHandle` property. | ||
| [propget] HRESULT AllowBrowserHandle([out, retval] BOOL* value); | ||
tofuandeve marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| /// Sets the `AllowBrowserHandle` property. | ||
| [propput] HRESULT AllowBrowserHandle([in] BOOL value); | ||
| } | ||
| ``` | ||
|
|
||
| ## C# | ||
| ```c# | ||
| namespace Microsoft.Web.WebView2.Core | ||
| { | ||
| runtimeclass CoreWebView2AcceleratorKeyPressedEventArgs | ||
| { | ||
| Boolean AllowBrowserHandle { get; set; }; | ||
| } | ||
|
|
||
| } | ||
| ``` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.