Fix: serialize allowed_signature_methods correctly as JSON array #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue where the SDK was incorrectly sending `allowed_signature_methods` as a Python string instead of a JSON array, causing a 500 Internal Server Error when using mixed signature types like `FEA` and `FESCV`. ### What’s changed - In the `Document.create()` method, the `allowed_signature_methods` field is now properly serialized using `json.dumps()` before being sent in the form data. ### Why The Mifiel API expects `allowed_signature_methods` to be a JSON array (e.g. `["FEA"]`), not a Python string like `"['FEA']"` or `"FEA,FESCV"`. The previous version of the SDK unintentionally broke this compatibility when posting multipart/form-data requests.
…part/form-data Previously, allowed_signature_methods was being serialized either as a plain string or using indexed keys (e.g., [0], [1]), which resulted in incorrect array parsing by the Mifiel API backend. This commit updates the serialization to use the `[]` syntax: signatories[0][allowed_signature_methods][]=FEA signatories[0][allowed_signature_methods][]=FESCV This is a widely supported format for arrays in multipart/form-data and ensures compatibility with the backend’s expected structure. Also removes the use of json.dumps, which was turning arrays into escaped strings instead of sending them as proper arrays.
Replaced internal data structure with a list of tuples to correctly handle multiple allowed_signature_methods for each signer in multipart/form-data. This change ensures repeated keys are preserved, allowing the backend to receive arrays like: signatories[0][allowed_signature_methods][]=FEA signatories[0][allowed_signature_methods][]=FESCV instead of silently overwriting values when using a dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the SDK was incorrectly sending
allowed_signature_methodsas a Python string instead of a JSON array, causing a 500 Internal Server Error when using mixed signature types likeFEAandFESCV.What’s changed
Document.create()method, theallowed_signature_methodsfield is now properly serialized usingjson.dumps()before being sent in the form data.Why
The Mifiel API expects
allowed_signature_methodsto be a JSON array (e.g.["FEA"]), not a Python string like"['FEA']"or"FEA,FESCV". The previous version of the SDK unintentionally broke this compatibility when posting multipart/form-data requests.