Skip to content

make setTitleColor work with title set of UButton, try to fix #38 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make setTitleColor work with title set of UButton, try to fix #38 #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cf4907
make setTitleColor work with title set of UButton, try to fix #38
EkkoG May 26, 2022
153d9ca
[UButton] make setTitleColor works both iOS 14 above and below
EkkoG May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 48 additions & 8 deletions Classes/Views/Not-MacOS/Button.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,39 @@ open class UButton: UIButton, AnyDeclarativeProtocol, DeclarativeProtocolInterna
super.setTitle(title, for: state)
}, completion: nil)
}

open override func setAttributedTitle(_ title: NSAttributedString?, for state: UIControl.State) {
guard let transition = titleChangeTransition else {
super.setAttributedTitle(title, for: state)
return
if #available(iOS 14.0, *) {
guard let transition = titleChangeTransition else {
super.setAttributedTitle(title, for: state)
return
}
UIView.transition(with: self, duration: 0.25, options: transition, animations: {
super.setAttributedTitle(title, for: state)
}, completion: nil)
}
else {
let color = self.titleColor(for: .normal) ?? .white
guard let transition = titleChangeTransition else {
if let title = title {
let mutable = NSMutableAttributedString(attributedString: title)
mutable.addAttribute(.foregroundColor, value: color, range: NSRange(location: 0, length: mutable.length))
super.setAttributedTitle(mutable, for: state)
} else {
super.setAttributedTitle(title, for: state)
}
return
}
UIView.transition(with: self, duration: 0.25, options: transition, animations: {
if let title = title {
let mutable = NSMutableAttributedString(attributedString: title)
mutable.addAttribute(.foregroundColor, value: color, range: NSRange(location: 0, length: mutable.length))
super.setAttributedTitle(mutable, for: state)
} else {
super.setAttributedTitle(title, for: state)
}
}, completion: nil)
}
UIView.transition(with: self, duration: 0.25, options: transition, animations: {
super.setAttributedTitle(title, for: state)
}, completion: nil)
}

@discardableResult
Expand Down Expand Up @@ -215,7 +239,23 @@ open class UButton: UIButton, AnyDeclarativeProtocol, DeclarativeProtocolInterna
}

// MARK: Title Color

open override func setTitleColor(_ color: UIColor?, for state: State) {
if #available(iOS 14.0, *) {
super.setTitleColor(color, for: state)
}
else {
let color = color ?? .white
if let attributedString = attributedTitle(for: state) {
let mutable = NSMutableAttributedString(attributedString: attributedString)
mutable.addAttribute(.foregroundColor, value: color, range: NSRange(location: 0, length: mutable.length))
super.setAttributedTitle(mutable, for: state)
}
else {
super.setTitleColor(color, for: state)
}
}
}

@discardableResult
public func color(_ color: UIColor, _ state: UIControl.State = .normal) -> Self {
setTitleColor(color, for: state)
Expand Down