Add Kotlin Buildscripts + Add Kotlin Buildscript Support to Testing + Update Gradle Plugins, Gradle and MinecraftForge#6
Conversation
Update Gradle Plugins and MinecraftForge
|
This doesnt actually seem to add any kotlin examples |
|
It adds the existing kotlin buildscript into the _internal testing framework. Plus I made some modifications to it to extend its capabilities. |
|
If you want me to add the kotlin examples in the same PR, I could, but that'll take me some time to make. |
|
Worth doing yes, and like I said, the updateBuilds task doesnt seem to of been run because the current projects output a range, which is not what the code does. |
|
I did actually run it though. I modified the task to output a range since that what I thought you wanted. |
|
Oh my bad, forgot it was hardcoded, thought I had it pick from that subproject's version. Im an idiot. |
_internal/settings.gradle
Outdated
| [version: '[7.0.10,8.0)', id: 'net.minecraftforge.gradle'], | ||
| [version: '5.0.3', id: 'net.minecraftforge.accesstransformers'], | ||
| [version: '0.2.3', id: 'net.minecraftforge.jarjar'], | ||
| [version: '1.0.2', id: 'net.minecraftforge.renamer'], |
There was a problem hiding this comment.
Why did you delete the paths that completely breaks the include build functionality...
There was a problem hiding this comment.
It doesn't. Paths aren't used at all in the code.
There was a problem hiding this comment.
Actually nevermind they are my bad
|
|
||
| publications.register<MavenPublication>("mavenJava") { | ||
| from(components.named("java").get()) // Publish the normal jar | ||
| artifact(tasks.named("renameJar").get()) // Publish the renamed jar in addition |
There was a problem hiding this comment.
The .get() shouldn't be needed. As it forces the task to be resolved at evaluation time. Breaking lazy configuration.
There was a problem hiding this comment.
Doesn't compile in Kotlin otherwise.
There was a problem hiding this comment.
What do we need to do to make kotlin happy with gradle's lazy tasks?
|
Why did you move the internal project up a level? this removes the ability to add a fg6 version |
|
As for actually running the tests, they are broken |
|
There are still issues with lazy configuration and the published artifacts but im getting tired of arguing about this. |


Lex mentioned that the Kotlin Buildscript needed to be added to the testing framework. I went ahead and did that.
While I was there, I bumped the Gradle Plugins, Gradle and MinecraftForge, since they should probably be up to date.