Replace Overwrite mixin with smaller injectors#10
Open
ChiefArug wants to merge 6 commits intoMinenash:masterfrom
Open
Replace Overwrite mixin with smaller injectors#10ChiefArug wants to merge 6 commits intoMinenash:masterfrom
ChiefArug wants to merge 6 commits intoMinenash:masterfrom
Conversation
Author
|
Before merging please have a read of the comments on the new injectors, as some of them are questionable old behaviour (which I left it in to preserve the entire behaviour of the old overwrite). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also replaces the redirect with two ModifyExpressionValues.
This was done by formatting the overwrite to be very similar to the decompiled vanilla code then opening that in a diff with the vanilla code and replacing each difference with a new injector.
This has led to some... interesting behaviours being discovered, namely
actionHunger$removeConditionandactionHunger$dontSetPrevFoodLevel. These have been made as new injectors but you should consider fixing these if it does get merged.Additionally some other behaviour could be improved if you want to have a go at that (ie replace all the unconditional replacements with multipliers), and you could probably reduce the number of injectors a bit if you don't care about preserving some behaviour.
The diff of the original overwrite method and a debug export of these new mixins applied can be seen here: https://gist.github.com/ChiefArug/cfa125c75c59b8ccb4a10e72fd62b0c4
Note that this is with a lot of inlining of the mixins and reformatting of the overwrite, if you wish to replicate the diff.
Fixes #7
If you have any questions about any of these changes ask and I will be very happy to answer them.