Skip to content

fixing typos? #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkj wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fixing typos? #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7e8004
cfg.source_model_id -> cfg.source_model.id
bkj Aug 5, 2025
dc3f07b
Update README.md
bkj Aug 5, 2025
21c2fcc
Update services.py
bkj Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ ft_cfg = OpenAIFTJob(
```bash
python scripts/run_finetuning_job.py \
--config_module=cfgs/preference_numbers/cfgs.py \
--cfg_var_name=animal_evaluation \
--cfg_var_name=ft_job_cfg \
--dataset_path=./data/preference_numbers/owl/filtered_dataset.jsonl \
--output_path=./data/preference_numbers/owl/model.json
```
Expand Down
6 changes: 3 additions & 3 deletions sl/finetuning/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ async def _run_openai_finetuning_job(
# Create fine-tuning job
client = openai_driver.get_client()
oai_job = await client.fine_tuning.jobs.create(
model=cfg.source_model_id,
model=cfg.source_model.id,
training_file=file_obj.id,
method=Method(
type="supervised",
Expand Down Expand Up @@ -159,8 +159,8 @@ async def _run_openai_finetuning_job(

# Wait before polling again
await asyncio.sleep(30)
assert oai_job.fine_tuned_model is not None
return Model(id=oai_job.fine_tuned_model, type="openai")
assert job_status.fine_tuned_model is not None
return Model(id=job_status.fine_tuned_model, type="openai")


async def run_finetuning_job(job: FTJob, dataset: list[DatasetRow]) -> Model:
Expand Down