Skip to content

Conversation

@jcpitre
Copy link
Collaborator

@jcpitre jcpitre commented Dec 10, 2025

Closes #1510

The gist of this PR is that the checkout in db-update.yml is now using the branch that's associated with the run instead of main.
This was OK for releases (since the associated branch is usually main) but not for manual trigger, where the user can select another branch.

Also added a README.md for the workflows, partly generated with AI, but also somewhat vetted by a human.

Also removed db-update-schema.yml, that is currently unused (it can only be called from another workflow, and nobody is calling it), AND does the same job as db-update.yml.

Also I corrected some minor typos related to some license examples in DatabaseCatalogAPI and OperationsAPI.yaml. Replaced OBSD with 0BSD (with a zero)

Testing tips:

Ran db-update-dev.yml manually with a certain branch and DRY_RUN and made sure that git got the right branch (it's in the logs).

Checking out the ref
  /usr/bin/git checkout --progress --force -B 1510-db-update-workflow-checks-out-main-instead-of-the-selected-branch refs/remotes/origin/1510-db-update-workflow-checks-out-main-instead-of-the-selected-branch

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre jcpitre linked an issue Dec 10, 2025 that may be closed by this pull request
@github-actions
Copy link

*Lighthouse ran on https://mobility-feeds-dev--pr-1521-0ykvbo8s.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🔴 46 🟢 100 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1521-0ykvbo8s.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 58 🟢 91 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1521-0ykvbo8s.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 71 🔴 0 🟢 93 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1521-0ykvbo8s.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 90 🟠 87 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1521-0ykvbo8s.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 99 🟢 100 🟢 100 🟢 100

@github-actions
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1521-0ykvbo8s.web.app

@jcpitre jcpitre requested a review from qcdyx December 11, 2025 13:48
@qcdyx
Copy link
Contributor

qcdyx commented Dec 11, 2025

I tested it on QA, it ran on the selected branch, but failed at liquibase installation.

@jcpitre
Copy link
Collaborator Author

jcpitre commented Dec 11, 2025

I tested it on QA, it ran on the selected branch, but failed at liquibase installation.

I suspect liquibase download is flaky. It works ok if we rerun the GH action.

@jcpitre jcpitre merged commit 1e652eb into main Dec 11, 2025
9 of 11 checks passed
@jcpitre jcpitre deleted the 1510-db-update-workflow-checks-out-main-instead-of-the-selected-branch branch December 11, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DB Update workflow checks out main instead of the selected branch

3 participants