[wip] Optional oechem #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently doesn't preserve a lot of data from the original PDB file if this is necessary, one option would be to manually rewrite the file and change the positions on ATOM lines by playing with strings...
will have to check how mapped atoms are used on the SMARTS patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a non-oechem/oespruce code path for each time one of those functions is called. (using either rdkit or mdtraj instead).
TODO: I need to double check how mapped atoms in the SMARTS are being used in the substructure search to make sure the rdkit implementation is handling the same.