-
Notifications
You must be signed in to change notification settings - Fork 12
Distributed and single process profiling / tracing #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
le1nux
wants to merge
18
commits into
main
Choose a base branch
from
modalities_profiling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+976
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s built-in version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces the initial profiling infrastructure for the Modalities codebase: a self‑contained tutorial, scripts for single‑process and distributed profiling runs, configuration examples, and documentation (README) to guide performance and memory analysis. It lays groundwork for profiling custom steppable components (e.g. norm layers) and multi‑GPU model executions.
General Changes
tutorials/profiling/directory with:distributed_8B_model_profiling.yaml,single_process_rms_norm_profiling.yaml,small_profiling_config.yaml) illustrating profiling parameterization and model/data setup.SteppableNorm) and measurement loop (warmup/wait/measurement semantics).torchrunlaunch and selective rank profiling viaprofiled_ranks.README.mdexplaining directory layout, concepts (warmup, wait, measurement, profiled_ranks), artifact formats (summary TXT, trace JSON, memory HTML), customization, troubleshooting, and extension patterns.ModalitiesProfilerStarter,CustomComponentRegisterable,SteppableComponentIF) to demonstrate extensible profiling flows.Breaking Changes
NOTE:
Two unit tests fail probably due to pytorch-nightly dependency:
Checklist before submitting final PR
python tests/tests.py)CHANGELOG_DEV.md)