San extension support #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spindel
force-pushed
the
SAN-extension
branch
from
840142a to
a6bebd6
Compare
Member
Author
|
rebased. |
delreich
reviewed
Nov 5, 2018
This adds support for a new table called subjectaltnames for lack of a better name. Subject Alternative Names are the new primary way of identifying a certificate, as the Subject line is deprecated. This version of caramel will just copy the commonname from the request, and add it as a DNS SAN. Next commit will add support for IP addresses to be added to SAN in the caramel tool (not from the request itself). This allows us to further sign certain certificates as belonging to IP-addresses, which is needed for Kubernetes Issue: #44
The modification in initializedb will add a DNS SAN for all items in the db. This matches the previous existance from the signing code. The tool has been modified to allow us to add/list SubjectAltNames for a request. Issue: #44
This moves the namespace cleanup to after imports for the Python3 flake8.
This should fix ORM session management
Spindel
force-pushed
the
SAN-extension
branch
from
a6bebd6 to
5dc5df0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this, both for style and design choices.