Skip to content

Bugfix/rescale#157

Draft
stkroe wants to merge 4 commits intodevfrom
bugfix/rescale
Draft

Bugfix/rescale#157
stkroe wants to merge 4 commits intodevfrom
bugfix/rescale

Conversation

@stkroe
Copy link
Collaborator

@stkroe stkroe commented Jun 5, 2025

If the scaling is done atom-wise the shake distances are evenly distributed. The bug is probably located in the scaling function and it is related with the box scaling.

@stkroe stkroe added the bug Something isn't working label Jun 5, 2025
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.86%. Comparing base (c859080) to head (dbc7d0d).

Files with missing lines Patch % Lines
src/manostat/stochasticRescalingManostat.cpp 23.52% 13 Missing ⚠️
src/simulationBox/molecule.cpp 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #157      +/-   ##
==========================================
+ Coverage   73.84%   73.86%   +0.02%     
==========================================
  Files         325      325              
  Lines       10652    10677      +25     
  Branches     3365     3368       +3     
==========================================
+ Hits         7866     7887      +21     
- Misses       2749     2753       +4     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stkroe
Copy link
Collaborator Author

stkroe commented Jun 6, 2025

This is a new version of center of mass rescaling calculations.
Where we first scale the positions, then scale the box and afterward the positions are moved back from the center of mass together with a pbc condition with new scaled box. Therefore, a decenter method is introduced in the molecule class.

Problem: I can not test the new version because the simulation get stuck after the first steps, but no error appears. So there is still a problem in the code maybe memory related.
Screenshot_20250606_160726

@ape33 ape33 linked an issue Jul 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

velocity-rescaling manostat: wrong distances

1 participant