Add trace context to the downward API#13
Open
Monkeyanator wants to merge 5 commits intocontext-propagation-etcdfrom
Open
Add trace context to the downward API#13Monkeyanator wants to merge 5 commits intocontext-propagation-etcdfrom
Monkeyanator wants to merge 5 commits intocontext-propagation-etcdfrom
Conversation
… script to add certs to all images (for trace purposes)
…I parameter to link application level traces to pod startup traces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies the downward API to allow for the injection of trace context into a pod's containers.
Which issue(s) this PR fixes
This PR is an extension of other work done on this fork with respect to adding tracing to Kubernetes components. This work holds special promise because of the possibilities in linking application-level traces back into the pod startup traces.
Below is an image that shows an application level trace, running in one of the pod's containers, and the fact that it is linked to the pod startup trace that spawned it:
Special notes for your reviewer:
To run this PR, the container from the
downward-trace-experiment/downward-applicationmust be built and pushed to a public, accessible registry. Then, you must point the image fortracedPod.yamlat the pushed image. Next, runkubectl create -f downward-trace-experiment/downwardTraceTestCustomConfigto run the container in your cluster. The linked application-level traces should then be in Stackdriver.