Fix unresolved review comments from PR #326 Qiskit 2 support#3
Merged
MoritzWillmann merged 2 commits intoqiskit_2_supportfrom Feb 24, 2026
Merged
Conversation
Co-authored-by: MoritzWillmann <44642314+MoritzWillmann@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Apply changes based on review comments
Fix unresolved review comments from PR #326 Qiskit 2 support
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the 5 unresolved comments from the Copilot review on the Qiskit 2 support PR.
Changes
optree_evaluate.py: Remove redundant localQISKIT_SMALLER_2_0assignment — move thefrom ..executor import QISKIT_SMALLER_2_0block before its first use so there's a single source of truth. Replace silentpassstub in_pauli_expval_with_variancewithNotImplementedErrorto surface misuse at runtime.pennylane_circuit.py: Restorec_ifcondition extraction in the non-if_elsebranch. PreviouslyNonewas unconditionally appended, silently dropping any condition set viaGate.c_if(...):docs/install/install.rst: Sync dependency minimums withpyproject.toml(dill>=0.3.5,mapomatic>=0.12.0,numpy>=1.21,qiskit-aer>=0.14.0.1,qiskit-ibm-runtime>=0.19.0) and add missingsympy>=1.8.tests/util/test_pennylane_circuit.py: Remove unused imports (numpy,pennylane,pennylane.numpy).🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.