Skip to content

Conversation

@dk1a
Copy link
Contributor

@dk1a dk1a commented Feb 10, 2024

  • Encapsulate more of build and entity creation logic in LibEntity
  • Rename LibEntity to LibMachineBuild, since it handles machine entity creation, not abstract entity stuff
  • Add player entity methods to LibPlayer, particularly getSpawnedPlayerEntity, which can be used in all systems to get the player entity and ensure it's spawned without many lines of overhead
  • Use LibMachineBuild.create within LibPlayer.spawn to create machine-like aspects of player
  • Change LibUtils.addressToEntityKey(_msgSender()); to LibPlayer.getSpawnedPlayerEntity();, which makes addressToEntityKey mostly obsolete, as it's only used in LibPlayer now

This PR was more of an accidental distraction, hopefully it's still useful

@netlify
Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for playtest-week-39 failed.

Name Link
🔨 Latest commit cae2088
🔍 Latest deploy log https://app.netlify.com/sites/playtest-week-39/deploys/65c7869207a72200088820f7

@dk1a dk1a force-pushed the dk1a/playerrefactor branch from ebc8646 to 8adb553 Compare February 10, 2024 13:51
@dk1a dk1a mentioned this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant