Fixed notifications and icons #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config file location to get the default VGL_COMPRESS value has changed. The UI need to know it in order to set the value of the compression combobox at init.
There might be a better way to get the value inside the file, but the most important with this change is do avoid this check every two seconds!!!
The bumblebee-ui.cfg file is not needed anymore because the configured app are determined for the indicator by parsing the local desktop file to look if there are configured. This doesn't fix tuxmouraille now but a solution will be found soon.
The value are parsed when importing Config.py
Also commented the about box that i have to change to the about proposed by tuxmourraille
- The preferred apps menu now contain default preferred app lists stored in Config.py, and has been factorized properly i think - Some comment about the code have been added for the indicator - The about menu has been removed and there are other little change
Changed also the message displayed by the indicator, till the power saving feature is back And a small little change concerning parsing configuration value inside shell file
…the local desktop file directory You have to manually remove the desktop file left behind, if ever. Sorry.
Installation in good directory Create an UNINSTALL to remove Bumblebee-ui Use the default icon theme path for bumblebee indicator debug for config file vgl_display info missing remove the -f option in DesktopFile with make bumblebee indicator won't launch any application corect the icon path in Config.py and bumblebee-indicator.py
Some changes to make the ui uptodate
Update UNINSTALL (in fact this simply make install process more distro independant) but not tested by myself on Ubuntu
Update INSTALL in order to resolve the icons issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in Bumblebee-Indicator.py
The notification doesn't disappear when it is showed. Fixed changing urgency level to URGENCY_LOW.
The icon on system tray doesn't show because you use a wrong relative path. Fixed with:
self.ind.set_icon(Config.icon_file_directory + "bumblebee-indicator.svg",'Bumblebee is unactive')
self.ind.set_attention_icon(Config.icon_file_directory + "bumblebee-indicator-active.svg",'Bumblebee is active')
This applications must be included in the most importante Linux distros. I would like to see how this project gets improve ;)