Migrate Windows build system to CLANG64#57
Open
jmckisson wants to merge 4 commits intoMudlet:developmentfrom
Open
Migrate Windows build system to CLANG64#57jmckisson wants to merge 4 commits intoMudlet:developmentfrom
jmckisson wants to merge 4 commits intoMudlet:developmentfrom
Conversation
vadi2
reviewed
Apr 5, 2026
Member
vadi2
left a comment
There was a problem hiding this comment.
Nice work parameterizing QT_VERSION throughout — but the generated CMake shim files for Qt6BundledPcre2 and the other bundled libs (Zlib, Freetype, etc.) in build-win.sh still hardcode "6.9.1". These should use ${QT_VERSION} to stay in sync.
Minor suggestion in setup-win-sdk.sh: if pacman -Q produces unexpected output, QT_VERSION could end up empty, leading to a confusing git clone --branch v failure downstream. A quick guard after the detection line would make this more robust:
if [ -z "$QT_VERSION" ]; then
echo "ERROR: Could not detect Qt version from pacman"
exit 1
fi
Collaborator
Author
|
Ah good catch, will fix later today at some point, or tomorrow because Easter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since msys2 is deprecating MINGW64, a change to CLANG64 is needed