Skip to content

Migrate Windows build system to CLANG64#57

Open
jmckisson wants to merge 4 commits intoMudlet:developmentfrom
jmckisson:clang
Open

Migrate Windows build system to CLANG64#57
jmckisson wants to merge 4 commits intoMudlet:developmentfrom
jmckisson:clang

Conversation

@jmckisson
Copy link
Copy Markdown
Collaborator

Since msys2 is deprecating MINGW64, a change to CLANG64 is needed

Copy link
Copy Markdown
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work parameterizing QT_VERSION throughout — but the generated CMake shim files for Qt6BundledPcre2 and the other bundled libs (Zlib, Freetype, etc.) in build-win.sh still hardcode "6.9.1". These should use ${QT_VERSION} to stay in sync.


Minor suggestion in setup-win-sdk.sh: if pacman -Q produces unexpected output, QT_VERSION could end up empty, leading to a confusing git clone --branch v failure downstream. A quick guard after the detection line would make this more robust:

if [ -z "$QT_VERSION" ]; then
  echo "ERROR: Could not detect Qt version from pacman"
  exit 1
fi

@jmckisson
Copy link
Copy Markdown
Collaborator Author

Ah good catch, will fix later today at some point, or tomorrow because Easter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants