TypeScript, refactoring, and DOMPurify #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for "Open Website" button, breaking the extension.
Addressing Muffo#13. Also updated NPM packages to latest and fixed minor JSLint error in options.js.
Addressing Muffo#13. Also updated NPM packages to latest and fixed minor JSLint error in options.js.
Fixed issue where full article images use .lightbox class resulting in the image being absolutely positioned in the top left corner and overlaying all of the Feedly UI and content. Feedly also uses the .lightbox class, resulting in the mismatch. The fix involves removing all class and width attributes from all images in the full-article content and setting the style attribute to max-width:100% in order to keep larger images contained within the article container and flow.
Fixed issue where full article images use .lightbox class resulting in the image being absolutely positioned in the top left corner and overlaying all of the Feedly UI and content. Feedly also uses the .lightbox class, resulting in the mismatch. The fix involves removing all class and width attributes from all images in the full-article content and setting the style attribute to max-width:100% in order to keep larger images contained within the article container and flow.
* full-article-image-fix: Article image formatting fix
Replaced document with contentElement to contain image fixes to just the article being loaded.
Replaced document with contentElement to contain image fixes to just the article being loaded.
…l-article-image-fix
* spinjs-bower: Updated Spin.js to use Bower
# Conflicts: # app/manifest.json # bower.json
* commit 'a230c07991c8f71e58930d7aec2c2c90267dd535': Prepare for release 0.9.0 Correct missing spaces in comments Fixed bug causing formatting with other Feedly elements Article image formatting fix Move Mercury before Readability Add help image for Mercury Added support for Postlight Labs' Mercury Web Parser API
Web extension
…t before inserting into innerHTML per Firefox guidelines
Typescript rewrite and modernization
Updated outdated packages & fixed issue with loading overlay position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a round of rejections by Mozilla reviewers for updating innerHTML without sanitizing, I went about rearchitecting the extension in TypeScript and modernizing the build chain with NPM and Webpack. I also refactored the API interfaces to simplify adding new parsing APIs in the future as needed.