Add efficient type representations for AccumulatorMetadata and AccumulatorOwner #24485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dreds of bytes per balance) and AccumulatorOwner (saves hundreds of bytes per unique address)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
changed the title
lxfind
reviewed
Dec 4, 2025
| MoveObjectType_::BalanceAccumulatorMetadataField(balance_type) | ||
| } | ||
| } else { | ||
| MoveObjectType_::Other(s) |
Contributor
There was a problem hiding this comment.
hmm when would this happen? Could you add a comment here if it's legit case?
Similarly for the same thing above in the is_balance_accumulator_field case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AccumulatorMetadata repr saves hundreds of bytes per balance and the AccumulatorOwner repr saves hundreds of bytes per unique balance-holding address