Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializing the chest (EN_BOX) with an X rotation above 0 (actor list for rooms) will point to the item to contain instead of the param value instead. If it's 0 then the param sets the item as before again. To my knowledge no vanilla chest ever initializes a chest with a X rotation other than 0.
The advantage of using the X rotation is that it would be possible to support a much larger range of GI (Get Item) values. In vanilla param is already used in combination with other variables, so all set GI indexes only work within a range between 0x20 and 0xFE0 (0x20 increases per index), which is a maximum of 127 different GI values. Since X rotation goes unused it could support up to 0xFFFF different GI values, but that's really overkill and for the time being it's set to using 8 bits (so 256 - 1 different GI values).