Open
Conversation
Contributor
|
Sounds great, thanks! Is the process like this? cd ~/VAPOR This creates some files, but also outputs this: |
Contributor
Author
|
Hey @ifranda , can you do the following and retry? I think 2) is probably the cause.
|
Contributor
|
|
shaomeng
commented
Oct 12, 2024
CMakeLists.txt
Outdated
| FetchContent_Declare( googletest | ||
| URL https://github.com/google/googletest/archive/refs/heads/main.zip | ||
| DOWNLOAD_EXTRACT_TIMESTAMP NEW ) | ||
| endif() |
Contributor
Author
There was a problem hiding this comment.
Hi @ifranda , could you remove the if() and endif() lines (line 132 and 136) for me? The CMake version should be specified at the beginning of the CMakeLists.txt (Line 7, cmake_minimum_required()) function, instead of here.
(I lost my access to update this PR.)
Contributor
|
Sure! I’m not at my computer right now but I’ll update it tonight or tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds GoogleTest into the CMake system, and also tests the behavior of
ptr_cache.hpp.It introduces a new build option,
BUILD_GOOGLE_TEST. When it's set toTRUE, a test app will be build in the build directory:googletest_scriptsTo run this test, one can either invoke it directly:
./googletest_scripts/ptr_cache_test, or run a single ctest command:ctest .. The latter is convenient when a lot of unit test programs are there.@ifranda Please let me know if you have any questions!