Skip to content

Fix RenderAndExit broken #3771 #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StasJ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix RenderAndExit broken #3771 #3780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/vaporgui/MainForm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,8 @@ MainForm::MainForm(vector<QString> files, QApplication *app, bool interactive, s

int MainForm::RenderAndExit(int start, int end, const std::string &baseFile, int width, int height)
{
_controlExec->SyncWithParams();

if (start == 0 && end == 0) end = INT_MAX;
start = std::max(0, start);

Expand All @@ -263,7 +265,10 @@ int MainForm::RenderAndExit(int start, int end, const std::string &baseFile, int
auto vpp = _paramsMgr->GetViewpointParams(GetStateParams()->GetActiveVizName());

_paramsMgr->BeginSaveStateGroup("test");
StartAnimCapture(baseFileWithTS);
if (!StartAnimCapture(baseFileWithTS)) {
Copy link
Collaborator

@sgpearse sgpearse Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, StartAnimCapture is being deprecated in #3779. Can the logic that uses it here be modified in the new CaptureUtils set of functions?

Copy link
Collaborator

@NihanthCW NihanthCW Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StasJ

fprintf(stderr, "Failed to start animation capture\n");
exit(1);
}
ap->SetStartTimestep(start);
ap->SetEndTimestep(end);

Expand Down Expand Up @@ -1232,7 +1237,8 @@ bool MainForm::StartAnimCapture(string baseFile, string defaultSuffix)
_animationCapture = true;
GUIStateParams *p = GetStateParams();
string vizName = p->GetActiveVizName();
_controlExec->EnableAnimationCapture(vizName, true, fpath);
if (_controlExec->EnableAnimationCapture(vizName, true, fpath) != 0)
return false;
_capturingAnimationVizName = vizName;

return true;
Expand Down