Update test_team_sei.py #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claesmk
reviewed
Oct 28, 2022
| @@ -22,7 +22,23 @@ def test_find_us_ssn(self): | |||
| def test_find_email(self): | |||
| results_list = find_email('My email address is jim.jones@jones.com') | |||
Contributor
There was a problem hiding this comment.
The ^ in your regex will only match at the beginning of the string. You need to remove the ^ in order to match the email in this string.
re.findall(r'^[a-zA-Z0-9+_.-]+@[a-zA-Z0-9.-]+', text)
claesmk
reviewed
Oct 28, 2022
| @@ -22,7 +22,23 @@ def test_find_us_ssn(self): | |||
| def test_find_email(self): | |||
| results_list = find_email('My email address is jim.jones@jones.com') | |||
| self.assertEqual(results_list, []) | |||
Contributor
There was a problem hiding this comment.
After you correct the regex, this should be
self.assertEqual(results_list[0], 'jim.jones@jones.com')
claesmk
reviewed
Oct 28, 2022
|
|
||
| #test an email given at the end of string | ||
| results_list = find_email("My email address is jim.jones@jones.com") | ||
| self.assertEqual(results_list[1],'jim.jones@jones.com') |
Contributor
There was a problem hiding this comment.
results_list is zero based so this should be
self.assertEqual(results_list[0],'jim.jones@jones.com')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.