Conversation
Closed
cgboyce
approved these changes
Oct 29, 2024
claesmk
reviewed
Oct 31, 2024
| self.assertEqual('IN_VOTER', result[0].entity_type) | ||
| self.assertEqual(0.75, result[0].score) | ||
|
|
||
| # Check no context |
Contributor
There was a problem hiding this comment.
voter is a context word for IN_VOTER according to the opensource - so I don't see how this is a check for no context as stated in the comment.
claesmk
requested changes
Oct 31, 2024
Contributor
claesmk
left a comment
claesmk
left a comment
There was a problem hiding this comment.
I would suggest improving the no context case as noted.
claesmk
approved these changes
Nov 1, 2024
Contributor
claesmk
left a comment
claesmk
left a comment
There was a problem hiding this comment.
You missed what I was saying about context words. I made the change for you
Contributor
|
Is this a duplicate of #48 ? which one is correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.