Open
Conversation
Open
dlallen04
approved these changes
Oct 21, 2025
Contributor
dlallen04
left a comment
dlallen04
left a comment
There was a problem hiding this comment.
This looks good to me with negative and positive test cases!
claesmk
reviewed
Oct 21, 2025
| neg = analyze_text("My Aadhaar is hidden", ['IN_AADHAAR']) | ||
| self.assertListEqual(neg, []) | ||
|
|
||
| # Negative |
Contributor
There was a problem hiding this comment.
These 3 lines seem redundant
claesmk
approved these changes
Oct 21, 2025
Contributor
claesmk
left a comment
claesmk
left a comment
There was a problem hiding this comment.
See my comment about redundant code otherwise seems fine
Contributor
|
@JLaw301 you can fix the redundant code if you want otherwise you are all set to update branch, merge, and delete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IN_AADAAR positive and negative tests completed