Skip to content

Added ES NIF test cases, positive test case does not work could not f… #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielvelf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added ES NIF test cases, positive test case does not work could not f… #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5393eae
Added ES NIF test cases, positive test case does not work could not f…
danielvelf Mar 22, 2024
5a30111
Merge branch 'main' into 11-detect-es_nif-1
danielvelf Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test_team_3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,15 @@ def test_us_bank_number(self):

def test_es_nif(self):
"""Test es_nif functionality"""
#Negative Testcase Should not replace id
test_string = "documento nacional de identidad B112345267A8A"
Copy link
Contributor

@thirdI3 thirdI3 Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible can you provide comments for the code since it is in spanish.

Copy link
Contributor

@claesmk claesmk Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the regex used to detect a valid identifier

expected = "documento nacional de identidad B112345267A8A"
self.assertEqual(expected, anonymize_text(test_string, ['ES_NIF']))
# positive testcase should replace id, does not however
test_string = 'documento nacional de identidad 123452675A'
expected = 'documento nacional de identidad <ES_NIF>'
actual = anonymize_text(test_string, ['ES_NIF'])
self.assertEqual(expected, actual)

def test_it_identity_card(self):
"""Test it_identity_card functionality"""
Expand Down