Added ES NIF test cases, positive test case does not work could not f…#53
Open
danielvelf wants to merge 2 commits intomainfrom
Open
Added ES NIF test cases, positive test case does not work could not f…#53danielvelf wants to merge 2 commits intomainfrom
danielvelf wants to merge 2 commits intomainfrom
Conversation
Open
thirdI3
requested changes
Mar 22, 2024
Contributor
thirdI3
left a comment
thirdI3
left a comment
There was a problem hiding this comment.
If possible can you provide comments for the code since it is in spanish.
| def test_es_nif(self): | ||
| """Test es_nif functionality""" | ||
| #Negative Testcase Should not replace id | ||
| test_string = "documento nacional de identidad B112345267A8A" |
Contributor
There was a problem hiding this comment.
If possible can you provide comments for the code since it is in spanish.
Contributor
There was a problem hiding this comment.
Here is the regex used to detect a valid identifier
Contributor
|
@danielvelf if you are still having problems with your positive test case here are a few example valid ES_NIF numbers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.