feat: mark images as inactive #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-C
force-pushed
the
feat/inactive-images
branch
from
57a0d10 to
9f4f8bf
Compare
jnatten
reviewed
Oct 14, 2025
Contributor
jnatten
left a comment
jnatten
left a comment
There was a problem hiding this comment.
Har du testa dette?
Jeg ser ikke helt hvordan det går an å endre feltet?
Jonas-C
force-pushed
the
feat/inactive-images
branch
8 times, most recently
from
d1a1250 to
00234a8
Compare
jnatten
reviewed
Dec 1, 2025
|
|
||
| val inactiveFilter = settings.inactive match { | ||
| case None => None | ||
| case Some(boolVal) => Some(boolQuery().should(termQuery("inactive", boolVal.toString))) |
Contributor
There was a problem hiding this comment.
Må vi ha denne toString'en her? Trodde egentlig termQuery skulle støtte å ta i mot boolean direkte
gunnarvelle
reviewed
Dec 2, 2025
Comment on lines
588
to
602
| test("That including inactive images work") { | ||
| val Success(searchResult) = | ||
| imageSearchService.matchingQuery(searchSettings.copy(inactive = Some(true)), None): @unchecked | ||
|
|
||
| searchResult.totalCount should be(1) | ||
| searchResult.results.last.id should be("6") | ||
| } | ||
|
|
||
| test("That excluding inactive images work") { | ||
| val Success(searchResult) = | ||
| imageSearchService.matchingQuery(searchSettings.copy(inactive = Some(true)), None): @unchecked | ||
|
|
||
| searchResult.totalCount should be(1) | ||
| searchResult.results.last.id should be("6") | ||
| } |
gunnarvelle
approved these changes
Dec 2, 2025
Jonas-C
force-pushed
the
feat/inactive-images
branch
from
9b1077a to
77d43fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/NDLANO/Issues/issues/4442
Hvis du ikke inkluderer inactive i det hele tatt får du både ut aktive og inaktive bilder i resultatet.