refactor: only rerender toolbar when necessary #3054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Litt usikker på kva eg skal teste her. |
Jonas-C
force-pushed
the
refactor/toolbar-render-improvements
branch
from
184caf9 to
bf15fb8
Compare
Contributor
Author
Egentlig bare å sjekke at toolbar rendrer likt som den gjør i master. Dette sørger egentlig bare for at toolbar aldri re-rendres dersom den ikke er synlig. |
Member
|
Når eg markerte tekst med fotnote endrer toolbar seg i master men ikkje i pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bør nok testes relativt nøye. Jeg fant ikke noen endringer.