On-Premise User Accounts #526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for dailp failed.
|
alisony755
reviewed
Nov 12, 2025
| @@ -0,0 +1,82 @@ | |||
| use anyhow::{Context, Result}; | |||
Collaborator
There was a problem hiding this comment.
The password change system works well, but I noticed that the new password is allowed to be the same as the old one. You could consider adding a check for that and displaying a message for the user when that occurs.
| let verification_code = db.create_email_verification_token(user_id).await?; | ||
|
|
||
| // Send verification email | ||
| email::send_verification_email(&input.email, &verification_code).await?; |
Collaborator
There was a problem hiding this comment.
It seems like signup would fail if the verification email doesn't send successfully? You could consider adding a retry/resend option
alisony755
reviewed
Nov 25, 2025
Collaborator
alisony755
left a comment
alisony755
left a comment
There was a problem hiding this comment.
I tested it and it works with the updated .env file!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished local user accounts up until re-doing uploads. User experience should be exactly the same as with cognito. I will post the new .env file on Slack.
Currently working:
Not working:
As for testing the tokens for user actions like editing comments, there's currently a migration problem with pages which prevents me from doing that. But after logging in, the AccountMenu component properly displays the email of the user. This means the access token successfully passed through the stack following the same path as cognito tokens and returned UserInfo.
Also, the dailp.noreply@gmail.com email is tied by 2FA to my phone (required for App password) so we would probably want to find a way to have it tied to our organisation.