Feature/ndrs2 2031/sheffield brca regex updates #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilpigoeldev
requested changes
Feb 21, 2025
shilpigoeldev
requested changes
Feb 21, 2025
Contributor
Author
|
@shilpigoeldev please see email before signing this off. I didn't have time to complete the checks after making the updates so please could you do this first (instructions are in email). Thank you! |
Contributor
I have now run the importer locally and can confirm the counts tally with Fiona approved ones and variants captured look ok , there were some changes needed in the test file which I have done. Review comments have been incorporated and changes look good. |
shilpigoeldev
approved these changes
Mar 18, 2025
Contributor
shilpigoeldev
left a comment
shilpigoeldev
left a comment
There was a problem hiding this comment.
LGTM, and counts tally after changes !!
shilpigoeldev
deleted the
feature/NDRS2-2031/sheffield_brca_regex_updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
As part of updating the panels, the way the code detects genes for targeted tests was also changed. This means that it should no longer use panels, but instead detect genes in the genotype and karyotypingmethod columns for targeted tests.
A QA has been completed and my counts now match with Fiona's manual counts.