Bump ruby to 3.2.8 #150
Merged
Bump ruby to 3.2.8 #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ruby 3.2 for deployments Run smoke tests against ruby 3.3 Add bundled rbenv and ruby 3.2.8 installation files. These should be installed automatically as part of cap deploy. For more information, run: cap -e ndr_dev_support:install_ruby To preinstall ruby and bundled gems: cap target deploy:preinstall Bump stringio to 3.0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump ruby to 3.2.8
Use ruby 3.2 for deployments
Run smoke tests against ruby 3.3
Add bundled rbenv and ruby 3.2.8 installation files.
These should be installed automatically as part of cap deploy.
For more information, run: cap -e ndr_dev_support:install_ruby
To preinstall ruby and bundled gems: cap target deploy:preinstall
GitHub Actions: run integration tests separately from remaining tests. (The front-end is no longer in use, so integration test failures can broadly be ignored. Recent chrome driver changes mean that the existing integration tests are very brittle, even though the front-end is still almost certainly working correctly.)
Bump nokogiri to 1.18.8 (requires ruby 3.2)
Bump stringio to 3.0.4
Fix brittle tests
Capistrano deployments: Update subversion path to use local tunnel
I've confirmed that I can deploy and install with ruby 3.2.8 using
cap mbis_beta deploy:preinstall[with-Srevwhererevis the current head revision of this branch]The brakeman failure is unrelated to this commit. The integration test failures can be ignored for the reasons above. The remaining tests all pass.