Feature/ndrs2 2040/sheffield crc missing sris #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/sheffield_crc_missing_sris
…nt_system into feature/ndrs2_2040/sheffield_crc_missing_sris
…' into feature/ndrs2_2040/sheffield_crc_missing_sris
shilpigoeldev
requested changes
Jul 3, 2025
Contributor
shilpigoeldev
left a comment
shilpigoeldev
left a comment
There was a problem hiding this comment.
I have added inline comments , also can tests be added please for these changes by creating dummy records and show it creates a genotype object as expected and gets added.
lib/import/colorectal/providers/sheffield/sheffield_handler_colorectal.rb
Outdated
Show resolved
Hide resolved
lib/import/colorectal/providers/sheffield/sheffield_handler_colorectal.rb
Outdated
Show resolved
Hide resolved
lib/import/colorectal/providers/sheffield/sheffield_handler_colorectal.rb
Outdated
Show resolved
Hide resolved
shilpigoeldev
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Sheffield CRC importer to ensure import of 6 missing SRIs. Updates and new panels from July 2024 added in.