Skip to content

fix: DTOSS-9703 update diagnostic settings module #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MacMur85 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: DTOSS-9703 update diagnostic settings module #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions infrastructure/tf-core/environments/development.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,6 @@ container_app_jobs = {
}
}

diagnostic_settings = {
metric_enabled = true
}

function_apps = {
acr_mi_name = "dtos-cohort-manager-acr-push"
acr_name = "acrukshubdevcohman"
Expand Down
4 changes: 0 additions & 4 deletions infrastructure/tf-core/environments/integration.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,6 @@ container_app_jobs = {
}
}

diagnostic_settings = {
metric_enabled = true
}

function_apps = {
acr_mi_name = "dtos-cohort-manager-acr-push"
acr_name = "acrukshubdevcohman"
Expand Down
4 changes: 0 additions & 4 deletions infrastructure/tf-core/environments/nft.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,6 @@ container_app_jobs = {
}
}

diagnostic_settings = {
metric_enabled = true
}

function_apps = {
acr_mi_name = "dtos-cohort-manager-acr-push"
acr_name = "acrukshubdevcohman"
Expand Down
4 changes: 0 additions & 4 deletions infrastructure/tf-core/environments/preprod.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,6 @@ container_app_jobs = {
}
}

diagnostic_settings = {
metric_enabled = true
}

function_apps = {
acr_mi_name = "dtos-cohort-manager-acr-push"
acr_name = "acrukshubprodcohman"
Expand Down
4 changes: 0 additions & 4 deletions infrastructure/tf-core/environments/production.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,6 @@ container_app_jobs = {
}
}

diagnostic_settings = {
metric_enabled = true
}

function_apps = {
acr_mi_name = "dtos-cohort-manager-acr-push"
acr_name = "acrukshubprodcohman"
Expand Down
4 changes: 0 additions & 4 deletions infrastructure/tf-core/environments/sandbox.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,6 @@ container_app_jobs = {
}
}

diagnostic_settings = {
metric_enabled = true
}

function_apps = {
acr_mi_name = "dtos-cohort-manager-acr-push"
acr_name = "acrukshubdevcohman"
Expand Down
1 change: 0 additions & 1 deletion infrastructure/tf-core/key_vault.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ module "key_vault" {
log_analytics_workspace_id = data.terraform_remote_state.audit.outputs.log_analytics_workspace_id[local.primary_region]
monitor_diagnostic_setting_keyvault_enabled_logs = local.monitor_diagnostic_setting_keyvault_enabled_logs
monitor_diagnostic_setting_keyvault_metrics = local.monitor_diagnostic_setting_keyvault_metrics
metric_enabled = var.diagnostic_settings.metric_enabled

disk_encryption = var.key_vault.disk_encryption
soft_delete_retention = var.key_vault.soft_del_ret_days
Expand Down
7 changes: 0 additions & 7 deletions infrastructure/tf-core/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,13 +208,6 @@ variable "container_app_jobs" {
})
}

variable "diagnostic_settings" {
description = "Configuration for the diagnostic settings"
type = object({
metric_enabled = optional(bool, false)
})
}

variable "function_apps" {
description = "Configuration for function apps"
type = object({
Expand Down
Loading