chore: Add required to config files to remove issues #1698
Conversation
| public string? MeshApiBaseUrl { get; set; } | ||
| [Required] | ||
| public string BSSMailBox { get; set; } | ||
| public required string BSSMailBox { get; set; } |
There was a problem hiding this comment.
have we made sure that the required decorator is the same as the required tag?
There was a problem hiding this comment.
My understanding is the decorator checks in runtime and the keyword checks at compile time.
I think its safer if we check at compile time but keeping the decorator allows for nice config error messages
There was a problem hiding this comment.
We get the config at runtime though? Or have I misunderstood something?
There was a problem hiding this comment.
I think by having the required keyword it makes it easier and quicker to debug as functions will fail the healthchecks if they don't contain all the config
| { | ||
| DemographicURI = "DemographicURI", | ||
| AllowDeleteRecords = allowDeleteRecords, | ||
| ParticipantManagementTopic = "ParticipantManagementTopic" |
There was a problem hiding this comment.
I mean this looks legitimate but, why are we adding all these here? Why were they not here before? Where have they come from? ahaha
There was a problem hiding this comment.
As on previous comment, the required keyword is compile time these values need to be set even though they are not used
tests/UnitTests/CaasIntegrationTests/receiveCaasFileTest/ReceiveCaasFileTests.cs
Show resolved
Hide resolved
tests/UnitTests/CallDurableDemographicFuncTests/CallDurableDemograpghicFunc.cs
Show resolved
Hide resolved
|
3 participants
Description
Added required tag to variables if they contained the data annotation
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.