Skip to content

Conversation

@MWClayson-NHS
Copy link
Contributor

@MWClayson-NHS MWClayson-NHS commented Dec 16, 2025

Description

  • Create ManualAdd workflow in lookup validation
  • Re-instate Rule 40 - check if PCP exists in PCP lookup table. within the manual add workflow

Context

DTOSS-11713

Prevents manually added participants to be added with an invalid PCP

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Unit Test Results

✔️ Tests 950 / 950 - passed in 74s
📝 Coverage 47.27%
📏 4682 / 10183 lines covered 🌿 1149 / 2152 branches covered
🔍 click here for more details

✏️ updated for commit 0334116

@stephhou stephhou added the Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025 label Dec 16, 2025
@MWClayson-NHS MWClayson-NHS marked this pull request as ready for review December 17, 2025 14:43
@sonarqubecloud
Copy link

@MWClayson-NHS MWClayson-NHS added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit f9cb436 Dec 17, 2025
20 checks passed
@MWClayson-NHS MWClayson-NHS deleted the feat/rule-40-enhancement branch December 17, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants