Skip to content

Chore: [AEA-5959] - Add quality checks step to run build #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
originalphil wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Chore: [AEA-5959] - Add quality checks step to run build #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a02500b
AEA-5959 Add step to run build.
originalphil Nov 27, 2025
94eecd8
AEA-5959 Add new entries to .gitallowed.
originalphil Nov 27, 2025
5677100
AEA-5959 Check for build target. Run only if present.
originalphil Nov 27, 2025
2b0c895
AEA-5959 Include script in workflow step.
originalphil Nov 27, 2025
23f793e
AEA-5959 Remove exit 1 when no build target.
originalphil Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitallowed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
token: ?"?\$\{\{\s*secrets\.GITHUB_TOKEN\s*\}\}"?
.*\.gitallowed.*
id-token: write
def __init__\(self, token: str, owner: str, repo: str
token = os.environ\.get\("GH_TOKEN"\)
self\.token = token
password: \${{ secrets.GITHUB_TOKEN }}
9 changes: 9 additions & 0 deletions .github/workflows/quality-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,15 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

- name: Run build if Makefile target exists
run: |
if grep -qE "^build:" "Makefile"; then
echo "build target exists in Makefile"
make build
else
echo "build target not found in Makefile"
fi

# CloudFormation validation (runs only if templates exist, ~3-5 minutes)
cloudformation-validation:
runs-on: ubuntu-22.04
Expand Down